Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed monopole ionisation #27426

Merged
merged 2 commits into from Jul 3, 2019

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jul 2, 2019

PR description:

The fix for the problem, which was reported to Geant4
https://bugzilla-geant4.kek.jp/show_bug.cgi?id=2169
This fix affect slow magnetic monopole ionisation (beta < 0.01).

PR validation:

private

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27426/10725

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27426/10729

  • This PR adds an extra 16KB to repository

@civanch
Copy link
Contributor Author

civanch commented Jul 2, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1296/console Started: 2019/07/02 18:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cca93e/1296/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3290686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3290350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Jul 3, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2019

+1

@civanch as this is a genuine physics fix, and it does not affect ordinary SM process simulation, I would suggest to backport it into 10_6_X for possible UL use

@cmsbuild cmsbuild merged commit 3cd8b87 into cms-sw:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants