PPS: update of association cuts #27440

jan-kaspar · 2019-07-04T09:52:22Z

This PR adjusts the "association cuts" used in multi-RP proton reconstruction. This update has been presented in RECO/AT meeting:
https://indico.cern.ch/event/830302/contributions/3477928/attachments/1871174/3079130/jan_kaspar_pps.pdf
and PPS POG meeting:
https://indico.cern.ch/event/832270/contributions/3487106/attachments/1872773/3082425/jan_kaspar_pps.pdf

The new association cuts are different for 2016, 2017 and 2018 - which is achieved by introducing new era modifiers. For backward compatibility the meaning of ctpps_2016 is unchanged and this modifier still applies to all 2016, 17 and 18.

The association cuts are modified for all 2016, 2017 and 2018.

This update is backported to the 10_6 cycle for later stages of UL re-reco in #27475.

cmsbuild · 2019-07-04T09:52:52Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-04T09:59:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27440/10747

This PR adds an extra 16KB to repository

cmsbuild · 2019-07-04T09:59:55Z

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

Configuration/Eras
RecoCTPPS/ProtonReconstruction

@perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @forthommel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2019-07-04T11:42:20Z

please test

cmsbuild · 2019-07-04T11:42:49Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1322/console Started: 2019/07/04 13:43

cmsbuild · 2019-07-04T14:47:17Z

+1
Tested at: fb87837
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdd71d/1322/summary.html

cmsbuild · 2019-07-04T14:47:20Z

Comparison job queued.

cmsbuild · 2019-07-04T17:10:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdd71d/1322/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 28 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3160399
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3160061
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

perrotta · 2019-07-06T12:54:44Z

Configuration/Eras/python/Era_Run2_2018_cff.py

@@ -15,7 +15,8 @@
 from Configuration.Eras.Modifier_run2_egamma_2018_cff import run2_egamma_2018
 from Configuration.Eras.Modifier_run2_egamma_2017_cff import run2_egamma_2017
 from Configuration.Eras.Modifier_run2_L1prefiring_cff import run2_L1prefiring
+from Configuration.Eras.Modifier_ctpps_2018_cff import ctpps_2018

 Run2_2018 = cms.ModifierChain(Run2_2017.copyAndExclude([run2_HEPlan1_2017, run2_muon_2017, run2_L1prefiring, run2_HLTconditions_2017, run2_egamma_2017]),


Shouldn't you exclude ctpps_2017 here? If I understand it correctly, your idea is to have 2017 and 2018 modifiers applying on top of ("default") 2016 modifiers.

Absolutely, thanks for catching this! Fixed in d8eb24c.

perrotta · 2019-07-06T13:03:46Z

RecoCTPPS/ProtonReconstruction/python/ctppsProtons_cff.py

+ctpps_2016.toModify(ctppsProtons, ApplyDefaultSettings) # applied for all Run2 years (2016, 2017 and 2018)
+
+def Apply2017Settings(ctppsProtons):
+  ctppsProtons.association_cuts_45.xi_cut_value = 0.010


Both these settings are identical to the "default" ones, i.e. you are not replacing anything here

Right, in the POG meeting we converged on identical settings for 2016 and 2017. For symmetry (and possible future updates) I kept the code separated for 2016 and 2017.

perrotta · 2019-07-06T13:05:43Z

RecoCTPPS/ProtonReconstruction/python/ctppsProtons_cff.py

+from Configuration.Eras.Modifier_ctpps_2017_cff import ctpps_2017
+from Configuration.Eras.Modifier_ctpps_2018_cff import ctpps_2018
+
+def ApplyDefaultSettings(ctppsProtons):


Start with a lowercase letter, as for cms code rules: applyDefaultSettings (and the same for the similar cases below)

Fixed in d8eb24c.

perrotta · 2019-07-06T13:26:17Z

By the way, the only difference visible in the jenkins tests is in the 2016 workflow 136.731, where an additional proton is reconstructed with the new settings.
This demonstrates that you are also modifying the setting for 2016 (where before this PR you were just relying on those set by the fillDescriptions method of CTPPSProtonProducer.cc, which are different from the ones set here with the ctpps_2016 modifier). I think that this is exactly what you want, but let me underline it here because it was not obvious from the PR description.

I imagine that the automated comparisons do not show differences in the 2017 or 2018 workflows just because of the low statistics.

cmsbuild · 2019-07-09T17:26:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1377/console Started: 2019/07/09 19:27

cmsbuild · 2019-07-09T19:48:24Z

+1
Tested at: d8eb24c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdd71d/1377/summary.html

cmsbuild · 2019-07-09T19:48:28Z

Comparison job queued.

cmsbuild · 2019-07-09T22:01:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdd71d/1377/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 28 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3160399
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3160061
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

perrotta · 2019-07-10T04:31:18Z

+1

Parameters for association cuts are updated separately for the last three years of data taking
Small changes with respect to the previous common default are shown in PPS: update of association cuts #27440 (comment) : jenkins tests pass and show no other differences besides the low-stat reflection of these changes.

perrotta · 2019-07-10T04:33:35Z

Please @jan-kaspar prepare the backpport to 10_6 that you have planned

jan-kaspar · 2019-07-10T09:52:15Z

Thanks @perrotta, the backport is here: #27475.

fabiocos · 2019-07-11T08:26:40Z

+operations

the update of Configuration eras is coherent with the purpose of the PR

fabiocos · 2019-07-11T08:26:45Z

+1

cmsbuild · 2019-07-11T08:27:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

PPS: update of association cuts (backport of #27440)

jan-kaspar added 2 commits July 4, 2019 11:40

Added ctpps_2017 and ctpps_2018 era modifiers.

b76b70b

Association cuts updated.

fb87837

cmsbuild added this to the CMSSW_11_0_X milestone Jul 4, 2019

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 4, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 4, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 4, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 4, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 4, 2019

perrotta reviewed Jul 6, 2019

View reviewed changes

Review suggestions implemented.

d8eb24c

cmsbuild removed the code-checks-approved label Jul 9, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 9, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 9, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 9, 2019

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 10, 2019

jan-kaspar mentioned this pull request Jul 10, 2019

PPS: update of association cuts (backport of #27440) #27475

Merged

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Jul 11, 2019

cmsbuild merged commit 7460523 into cms-sw:master Jul 11, 2019

cmsbuild added a commit that referenced this pull request Aug 6, 2019

Merge pull request #27475 from CTPPS/association_cuts_10_6

e74f6d2

PPS: update of association cuts (backport of #27440)

cmsbuild mentioned this pull request Aug 7, 2019

Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL [10_6_X] #27698

Closed

fabiocos mentioned this pull request Aug 7, 2019

Restore updated PPS association cuts for 2017 #27709

Merged

jan-kaspar deleted the association_cuts branch December 12, 2019 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPS: update of association cuts #27440

PPS: update of association cuts #27440

jan-kaspar commented Jul 4, 2019 •

edited

Loading

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

perrotta commented Jul 4, 2019

cmsbuild commented Jul 4, 2019 •

edited

Loading

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

perrotta Jul 6, 2019

jan-kaspar Jul 9, 2019

perrotta Jul 6, 2019

jan-kaspar Jul 9, 2019

perrotta Jul 6, 2019

jan-kaspar Jul 9, 2019

perrotta commented Jul 6, 2019

cmsbuild commented Jul 9, 2019 •

edited

Loading

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

perrotta commented Jul 10, 2019

perrotta commented Jul 10, 2019

jan-kaspar commented Jul 10, 2019

fabiocos commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

PPS: update of association cuts #27440

PPS: update of association cuts #27440

Conversation

jan-kaspar commented Jul 4, 2019 • edited Loading

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

perrotta commented Jul 4, 2019

cmsbuild commented Jul 4, 2019 • edited Loading

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

cmsbuild commented Jul 4, 2019

perrotta Jul 6, 2019

Choose a reason for hiding this comment

jan-kaspar Jul 9, 2019

Choose a reason for hiding this comment

perrotta Jul 6, 2019

Choose a reason for hiding this comment

jan-kaspar Jul 9, 2019

Choose a reason for hiding this comment

perrotta Jul 6, 2019

Choose a reason for hiding this comment

jan-kaspar Jul 9, 2019

Choose a reason for hiding this comment

perrotta commented Jul 6, 2019

cmsbuild commented Jul 9, 2019 • edited Loading

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

perrotta commented Jul 10, 2019

perrotta commented Jul 10, 2019

jan-kaspar commented Jul 10, 2019

fabiocos commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

jan-kaspar commented Jul 4, 2019 •

edited

Loading

cmsbuild commented Jul 4, 2019 •

edited

Loading

cmsbuild commented Jul 9, 2019 •

edited

Loading