New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TkAl Millepede: improve file copying and copy error reporting #27492
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27492/10825
|
A new Pull Request was created by @adewit for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adds checksum comparison to copies from eos to the worker node to reduce failure rate.
Avoids reporting an error for the 2nd step of the alignment if copies from eos fail, as this can happen when a file is excluded from the alignment but not from the copy command to the worker node.
PR validation:
Changes verified to work in the alignment workflow, nothing external is affected
if this PR is a backport please specify the original PR:
Not a backport