-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry: Move DOMCount Regression Test to Geometry/CMSCommonData #27495
Conversation
The code-checks are being triggered in jenkins. |
@smuzaffar and @mrodozov - FYI. This should fix the regular failures for good. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27495/10827
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/RegressionTest @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@ianna @smuzaffar as far as I can see this addresses the failure https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc700/CMSSW_11_0_X_2019-07-11-1100/unitTestLogs/DetectorDescription/RegressionTest#/3445-3445 starting in CMSSW_11_0_X_2019-07-10-2300 due to the update in #27449 |
Comparison job queued. |
+1 |
Yes, we've discussed this with @mrodozov and @smuzaffar this morning. If @kpedro88 has time he could update the shell script to pick up the list of files for the test automatically... |
@ianna I will rebase the renaming PR on top of this one and try to automate the list of phase 2 geometry files used here |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 @ianna thanks for fixing the problem. I am not sure that moving the test in another place will significantly improve the situation in case of changes, but it does not harm and it may be logically motivated |
PR description:
PR validation:
scram b runtests
should trigger an appropriate testif this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: