Geometry: Move DOMCount Regression Test to Geometry/CMSCommonData

[ianna]

PR description:

• The DOMCount test has been failing regularly due to the frequent changes in the list of the scenarios. Move it closer to the responsible for the changes package.

PR validation:

scram b runtests should trigger an appropriate test

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

@smuzaffar and @mrodozov - FYI. This should fix the regular failures for good.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27495/10827

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/RegressionTest
Geometry/CMSCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1421/console Started: 2019/07/11 13:48

[fabiocos]

@ianna @smuzaffar as far as I can see this addresses the failure https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc700/CMSSW_11_0_X_2019-07-11-1100/unitTestLogs/DetectorDescription/RegressionTest#/3445-3445 starting in CMSSW_11_0_X_2019-07-10-2300 due to the update in #27449

[cmsbuild]

+1
Tested at: 56dffae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5de343/1421/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

+1

[ianna]

@ianna @smuzaffar as far as I can see this addresses the failure https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc700/CMSSW_11_0_X_2019-07-11-1100/unitTestLogs/DetectorDescription/RegressionTest#/3445-3445 starting in CMSSW_11_0_X_2019-07-10-2300 due to the update in #27449

Yes, we've discussed this with @mrodozov and @smuzaffar this morning. If @kpedro88 has time he could update the shell script to pick up the list of files for the test automatically...

[kpedro88]

@ianna I will rebase the renaming PR on top of this one and try to automate the list of phase 2 geometry files used here

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5de343/1421/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5de343/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5de343/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5de343/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3081858
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3081534
• DQMHistoTests: Total skipped: 322
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

@ianna thanks for fixing the problem. I am not sure that moving the test in another place will significantly improve the situation in case of changes, but it does not harm and it may be logically motivated