Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Phase2 workflows #27449

Merged
merged 6 commits into from Jul 10, 2019
Merged

Clean up Phase2 workflows #27449

merged 6 commits into from Jul 10, 2019

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Jul 5, 2019

PR description:

Resolves #26938.

Outdated Phase2 subdetectors, detectors, and workflows are removed. A now-unnecessary special workflow is also removed (the "Timing" option, since all supported workflows now include MTD + use of timing in reco).

The number of places to edit in order to add new workflows is reduced by automating the deepcopy for PU workflows and the initialization of default datasets.

Two new workflows are added to keep alive the T15 tracker and the HF nose, since the previous workflows with those subdetectors used now-unsupported versions of other subdetectors.

Workflow numbers are reset and the short matrix is updated accordingly. (This will cause spurious comparison differences.)

The 2023 -> 2026 renaming will come in a subsequent PR, because this one is already huge and that one will also be huge.

PR validation:

Tested that runTheMatrix works correctly.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27449/10761

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1344/console Started: 2019/07/05 19:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2019

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData

@cmsbuild, @prebello, @Dr15Jones, @cvuosalo, @civanch, @ianna, @mdhildreth, @pgunnell, @franzoni, @kpedro88, @zhenhu, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2019

-1

Tested at: 72c1b09

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-059825/1344/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
21234.0 step1

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2019

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 9, 2019

@cvuosalo, @ianna, @prebello, @pgunnell, @franzoni, @zhenhu please sign so we can move on to the next step (renaming 2023 -> 2026)

@prebello
Copy link
Contributor

prebello commented Jul 9, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jul 9, 2019

+operations

the update to Configuration is coherent with the purpose of the PR

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phase 2 geometry cleanup in 11_X
7 participants