Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper table columns for HGCAL objects in Fireworks #27508

Merged
merged 1 commit into from Jul 14, 2019

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jul 12, 2019

PR description:

This PR will add columns that are extremely useful for debugging/visualization purposes to HGCAL related objects

PR validation:

Tested locally running Fireworks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@rovere rovere changed the title Add proper table columns for HGCAL objects Add proper table columns for HGCAL objects in Fireworks Jul 12, 2019
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27508/10857

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1451/console Started: 2019/07/12 16:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor

alja commented Jul 12, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants