Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate More to New Random Service Interface #2751

Merged
merged 1 commit into from Mar 8, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Mar 6, 2014

Migrate some particle gun generator code
to use the new interface of the random number generator
service designed to work with the multithreaded Framework.
(I just inadvertently missed these in the previous
pull requests.)

Migrate some particle gun generator code
to use the new interface of the random number generator
service designed to work with the multithreaded Framework.
(I just inadvertently missed these in the previous
pull requests.)
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X.

Migrate More to New Random Service Interface

It involves the following packages:

IOMC/ParticleGuns

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

@Dr15Jones
Copy link
Contributor

+1
@ktf Any idea why this needs a core signature and not generators?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Mar 8, 2014

Good question... It's the same in the old TC. @vciulli any objections to make it generators?

ktf added a commit that referenced this pull request Mar 8, 2014
Multithreading -- Migrate More to New Random Service Interface
@ktf ktf merged commit 78518a9 into cms-sw:CMSSW_7_1_X Mar 8, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@vciulli
Copy link
Contributor

vciulli commented Mar 11, 2014

@ktf: sure, no problem to make it generators

@ktf
Copy link
Contributor

ktf commented Mar 11, 2014

@Degano can you take care of this? thanks.

@wddgit wddgit deleted the migrateToNewRandomService6 branch April 25, 2014 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants