Fix undefined behaviour problems in RecoTracker/TkHitPairs #27524
Conversation
This was found by UBSAN.
This was found by UBSAN.
|
The code-checks are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27524/10892
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoTracker/TkHitPairs @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -152,6 +152,8 @@ void HitPairGeneratorFromLayerPair::doublets(const TrackingRegion& region, | |||
| for (int j = 0; j < 3; j += 2) { | |||
| auto b = innerRange[j]; | |||
| auto e = innerRange[j + 1]; | |||
| if (e == b) | |||
There was a problem hiding this comment.
Isn't if (e <= b) even safer?
There was a problem hiding this comment.
If b > e then the whole algorithm would be busted, wouldn't it?
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27524/10947
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The following are meant to fix problems seen in the UBSAN IB.
PR validation:
The code compiles.