Avoid copying uninitialized value in PFDisplacedVertexCandidateFinder #27525
Conversation
Use constructor rather than operator= in order to avoid reading from an uninitialized valued in TwoTrackMinimumDistance. This was found by UBSAN.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27525/10893
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoParticleFlow/PFTracking @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -18,10 +18,9 @@ PFDisplacedVertexCandidateFinder::PFDisplacedVertexCandidateFinder() | |||
| primaryVertexCut2_(0.0), | |||
| dcaPInnerHitCut2_(1000.0), | |||
| vertexCandidatesSize_(50), | |||
| debug_(false) { | |||
| TwoTrackMinimumDistance theMinimum(TwoTrackMinimumDistance::SlowMode); | |||
There was a problem hiding this comment.
Out of curiosity @Dr15Jones, and for my own education: what was uninitialized here?
There was a problem hiding this comment.
The original error report was
TrackingTools/PatternTools/interface/TwoTrackMinimumDistance.h:19:7: runtime error: load of value 32508, which is not a valid value for type 'Charge'
|
+1 |
PR description:
Use constructor rather than operator= in order to avoid reading from
an uninitialized valued in TwoTrackMinimumDistance.
This was found by UBSAN.
PR validation:
Code compiles.