-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scenario Run3 to Configuration/DataProcessing #27536
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27536/10913
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/DataProcessing @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test just the unit test will probe this code |
The tests are being triggered in jenkins. |
Thank you @fabiocos ! |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27536/10914
|
self.eras=Run3 | ||
self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ] | ||
self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018_express_trackingOnly' ] | ||
self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these correct customs?
My guess is that at least the prompt and vis should stay with Run3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, given there is customisePostEra_Run3_express_trackingOnly, all of the above should be Run3*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slava77 this was just overlooked, fixing it
please abort |
please test |
The tests are being triggered in jenkins. |
Pull request #27536 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again. |
Comparison is ready Comparison Summary:
|
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Extend Configuration/DataProcessing including Era_Run3 as Run3_2021. HI and special settings are not considered for the time being.
No change to Era_Run3 is done, I let the move to year-based eras as discussed with @boudoul and @kpedro88 for a separate PR, given the urgency of this one.
PR validation:
The unit test passes, the code is a direct extension of the Run2 counterpart.