Add scenario Run3 to Configuration/DataProcessing #27536

fabiocos · 2019-07-16T18:55:34Z

PR description:

Extend Configuration/DataProcessing including Era_Run3 as Run3_2021. HI and special settings are not considered for the time being.
No change to Era_Run3 is done, I let the move to year-based eras as discussed with @boudoul and @kpedro88 for a separate PR, given the urgency of this one.

PR validation:

The unit test passes, the code is a direct extension of the Run2 counterpart.

cmsbuild · 2019-07-16T18:56:03Z

The code-checks are being triggered in jenkins.

fabiocos · 2019-07-16T18:58:56Z

@boudoul FYI @slava77 could you please cross check? For DataProcessing it makes sense to me to have directly a 2021 era, even if for the time being there is just Era_Run3 (but we already discussed about labelling it by year).

cmsbuild · 2019-07-16T19:04:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27536/10913

This PR adds an extra 16KB to repository

cmsbuild · 2019-07-16T19:05:29Z

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2019-07-16T19:06:21Z

please test

just the unit test will probe this code

cmsbuild · 2019-07-16T19:06:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1493/console Started: 2019/07/16 21:08

boudoul · 2019-07-16T19:57:08Z

Thank you @fabiocos !

cmsbuild · 2019-07-16T21:08:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-16T21:16:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27536/10914

This PR adds an extra 20KB to repository
Found files with invalid states:
- Configuration/DataProcessing/python/Impl/ppEra_Run3_2021.py:
  - Added: ff4e084
  - Deleted: 51d8ce6
- Configuration/DataProcessing/python/Impl/cosmicsEra_Run3_2021.py:
  - Added: ff4e084
  - Deleted: 51d8ce6
- Configuration/DataProcessing/test/ppEra_Run3_2021_t.py:
  - Added: ff4e084
  - Deleted: 51d8ce6
- Configuration/DataProcessing/python/Impl/hcalnzsEra_Run3_2021.py:
  - Added: ff4e084
  - Deleted: 51d8ce6
- Configuration/DataProcessing/python/Impl/trackingOnlyEra_Run3_2021.py:
  - Added: ff4e084
  - Deleted: 51d8ce6
- Configuration/DataProcessing/test/cosmicsEra_Run3_2021_t.py:
  - Added: ff4e084
  - Deleted: 51d8ce6

slava77 · 2019-07-16T21:18:05Z

Configuration/DataProcessing/python/Impl/trackingOnlyEra_Run3.py

+        self.eras=Run3
+        self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ]
+        self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018_express_trackingOnly' ]
+        self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018' ]


are these correct customs?
My guess is that at least the prompt and vis should stay with Run3

ah, given there is customisePostEra_Run3_express_trackingOnly, all of the above should be Run3*

@slava77 this was just overlooked, fixing it

fabiocos · 2019-07-16T21:18:10Z

please abort

fabiocos · 2019-07-16T21:30:34Z

please test

cmsbuild · 2019-07-16T21:30:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1497/console Started: 2019/07/16 23:32

cmsbuild · 2019-07-16T21:30:49Z

Pull request #27536 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

cmsbuild · 2019-07-16T23:33:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-309e79/1493/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081535
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

cmsbuild · 2019-07-16T23:36:19Z

+1
Tested at: 647ebf3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-309e79/1497/summary.html

cmsbuild · 2019-07-16T23:36:22Z

Comparison job queued.

cmsbuild · 2019-07-17T02:35:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-309e79/1497/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081534
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2019-07-17T05:21:42Z

+operations

fabiocos · 2019-07-17T05:22:08Z

+1

cmsbuild · 2019-07-17T05:22:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Add scenario Run3 to Configuration/DataProcessing

ff4e084

cmsbuild added this to the CMSSW_11_0_X milestone Jul 16, 2019

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures tests-pending labels Jul 16, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2019

fabiocos mentioned this pull request Jul 16, 2019

Add scenario Run3 to Configuration/DataProcessing #27537

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 16, 2019

Add scenario Run3 to Configuration/DataProcessing without _2021

51d8ce6

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Jul 16, 2019

slava77 reviewed Jul 16, 2019

View reviewed changes

cmsbuild removed the code-checks-pending label Jul 16, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 16, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 16, 2019

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jul 16, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 17, 2019

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Jul 17, 2019

cmsbuild merged commit 11f6941 into cms-sw:master Jul 17, 2019

fabiocos deleted the fc-DPRun3 branch August 7, 2019 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add scenario Run3 to Configuration/DataProcessing #27536

Add scenario Run3 to Configuration/DataProcessing #27536

fabiocos commented Jul 16, 2019 •

edited

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 16, 2019

cmsbuild commented Jul 16, 2019 •

edited

boudoul commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

slava77 Jul 16, 2019 •

edited

slava77 Jul 16, 2019

fabiocos Jul 16, 2019

fabiocos commented Jul 16, 2019

fabiocos commented Jul 16, 2019

cmsbuild commented Jul 16, 2019 •

edited

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 17, 2019

fabiocos commented Jul 17, 2019

fabiocos commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

Add scenario Run3 to Configuration/DataProcessing #27536

Add scenario Run3 to Configuration/DataProcessing #27536

Conversation

fabiocos commented Jul 16, 2019 • edited

PR description:

PR validation:

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

fabiocos commented Jul 16, 2019

cmsbuild commented Jul 16, 2019 • edited

boudoul commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

slava77 Jul 16, 2019 • edited

Choose a reason for hiding this comment

slava77 Jul 16, 2019

Choose a reason for hiding this comment

fabiocos Jul 16, 2019

Choose a reason for hiding this comment

fabiocos commented Jul 16, 2019

fabiocos commented Jul 16, 2019

cmsbuild commented Jul 16, 2019 • edited

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 16, 2019

cmsbuild commented Jul 17, 2019

fabiocos commented Jul 17, 2019

fabiocos commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

fabiocos commented Jul 16, 2019 •

edited

cmsbuild commented Jul 16, 2019 •

edited

slava77 Jul 16, 2019 •

edited

cmsbuild commented Jul 16, 2019 •

edited