Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call TClass::New for each container element #2755

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 7, 2014

This fixes the huge time consumption for the ROOT6 relvals,
In the conditions code, TClass::New was called for each element of a collection, which is not a good idea for over 100K emements. This fix calls it once for each container and reuses the memory.
This is a HUGE time savings.
Please merge ASAP, and the ROOT6 IB's should actually finish in a finite amount of time.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Don't call TClass::New for each container element

It involves the following packages:

CondCore/ORA

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Mar 7, 2014
Don't call TClass::New for each container element
@davidlt davidlt merged commit 97407ee into cms-sw:CMSSW_7_1_ROOT6_X Mar 7, 2014
@wmtan wmtan deleted the AvoidCallingTClassNewForEachElement branch March 9, 2014 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants