Don't call TClass::New for each container element #2755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the huge time consumption for the ROOT6 relvals,
In the conditions code, TClass::New was called for each element of a collection, which is not a good idea for over 100K emements. This fix calls it once for each container and reuses the memory.
This is a HUGE time savings.
Please merge ASAP, and the ROOT6 IB's should actually finish in a finite amount of time.