[BugFix] DDG4ProductionCuts Debug Printout

[ianna]

PR description:

• Instead of printing
  • a G4RegionStore pointer, print the G4RegionStore size
  • a G4Region pointer, print its name

  num  1 regionName: ZDCRegion, the store of size 2
DDG4ProductionCuts : regionName ZDCRegion, the store of size 2
DDG4ProductionCuts : region ZDCRegion
DDG4ProductionCuts : new G4Region ZDC
  num  1 regionName: TrackerDeadRegion, the store of size 3
DDG4ProductionCuts : regionName TrackerDeadRegion, the store of size 3
DDG4ProductionCuts : region TrackerDeadRegion
DDG4ProductionCuts : new G4Region Tracker
  num  1 regionName: TrackerSensRegion, the store of size 4
DDG4ProductionCuts : regionName TrackerSensRegion, the store of size 4
DDG4ProductionCuts : region TrackerSensRegion
DDG4ProductionCuts : new G4Region TOBWaferRphi4
  num  1 regionName: TrackerSensRegion, the store of size 5
  num  1 regionName: TrackerSensRegion, the store of size 5

here is how it was before:

  num  1 regionName: ZDCRegion 0x7fcdd78a12e0
DDG4ProductionCuts : regionName ZDCRegion 0x7fcdd78a12e0
DDG4ProductionCuts : region 0x7fcdcd3e9cc0
DDG4ProductionCuts : new G4Region ZDC
  num  1 regionName: TrackerDeadRegion 0x7fcdd78a12e0
DDG4ProductionCuts : regionName TrackerDeadRegion 0x7fcdd78a12e0
DDG4ProductionCuts : region 0x7fcdcd3e9d80
DDG4ProductionCuts : new G4Region Tracker
  num  1 regionName: TrackerSensRegion 0x7fcdd78a12e0
DDG4ProductionCuts : regionName TrackerSensRegion 0x7fcdd78a12e0
DDG4ProductionCuts : region 0x7fcdcd3e9e40
DDG4ProductionCuts : new G4Region TOBWaferRphi4
  num  1 regionName: TrackerSensRegion 0x7fcdd78a12e0
  num  1 regionName: TrackerSensRegion 0x7fcdd78a12e0

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27597/11024

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Geometry/src/DDG4ProductionCuts.cc modified in PR(s): DD4hep:Simulation - DDDWorld Defines Regions and Sets G4 Production Cuts #27588

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27597/11024/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27597/11024/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27597/11025

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4Core/Geometry/src/DDG4ProductionCuts.cc modified in PR(s): DD4hep:Simulation - DDDWorld Defines Regions and Sets G4 Production Cuts #27588

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1615/console Started: 2019/07/24 18:10

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4Core/Geometry

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 144a303
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fe51d/1615/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fe51d/1615/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2628546
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2628227
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27597/11046

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #27597 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1630/console Started: 2019/07/25 11:34

[cmsbuild]

+1
Tested at: f4d6955
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fe51d/1630/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Phase2-hgx207 Have uniform wafer type from HGCalDDDConst and reduce usage of magic numbers #27585 @bsunanda: Phase2-hgx207 Have uniform wafer type from HGCalDDDConst and reduce usage of magic numbers
• DD4hep:Simulation - DDDWorld Defines Regions and Sets G4 Production Cuts #27588 @ianna: DD4hep:Simulation - DDDWorld Defines Regions and Sets G4 Production Cuts
• TRK POG Phase2 : limit highPurity tracks up to |eta| < 4.0 #27520 @mtosi: TRK POG Phase2 : limit highPurity tracks up to |eta| < 4.0
• PFAlgo thread-safe logging #27505 @jpata: PFAlgo thread-safe logging
• Enhancements to support the magnetic field geometry builder #27574 @cvuosalo: Enhancements to support the magnetic field geometry builder

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fe51d/1630/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fe51d/1630/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fe51d/1630/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 301 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2628546
• DQMHistoTests: Total failures: 880
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2627349
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1
there is 880 failures in DQM but this cannot be due to this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1