Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sim]: Sensitive Detector Catalog Cleanup #27598

Merged
merged 1 commit into from Jul 26, 2019
Merged

[Sim]: Sensitive Detector Catalog Cleanup #27598

merged 1 commit into from Jul 26, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jul 24, 2019

PR description:

  • Make sure the class name is registered only once. The original version places the same class name as many times as the number of its ROUs. This feature is not used anywhere. Besides the accessors would return almost endless lists. Hence the question if the methods are still needed.
  • Provide its printMe for debugging purposes

@civanch - we need to discuss if all the methods of the class are useful

Class names map size is: 8

#1: BSCSensitiveDetector has 1 class names:
BSCHits, 
#2: CaloTrkProcessing has 1 class names:
CaloHitsTk, 
#3: CastorSensitiveDetector has 1 class names:
CastorFI, 
#4: EcalSensitiveDetector has 3 class names:
EcalHitsES, EcalHitsEB, EcalHitsEE, 
#5: HcalSensitiveDetector has 1 class names:
HcalHits, 
#6: MuonSensitiveDetector has 4 class names:
MuonGEMHits, MuonCSCHits, MuonRPCHits, MuonDTHits, 
#7: TkAccumulatingSensitiveDetector has 6 class names:
TrackerHitsTEC, TrackerHitsTIB, TrackerHitsPixelEndcap, TrackerHitsTOB, TrackerHitsTID, TrackerHitsPixelBarrel, 
#8: ZdcSensitiveDetector has 1 class names:
ZDCHITS, 

ROU names map: 18

#1: BSCHits has 4 ROU names:
BSCPadActive, BSCBottomTrapezoid, BSC2Pad, BSCTopTrapezoid, 
#2: CaloHitsTk has 1 ROU names:
CALO, 
#3: CastorFI has 5 ROU names:
C4HF, C3HF, C4EF, CAST, C3EF, 
#4: EcalHitsEB has 102 ROU names:
EATJ_15_refl, EAPD_13_refl, EATJ_13_refl, EATJ_12_refl, EBRY_12_refl, EAPD_11_refl, EBRY_15_refl, EATJ_11_refl, EBRY_11_refl, EAPD_10_refl, EATJ_10_refl, EBRY_10_refl, EBRY_09_refl, EBRY_13_refl, EAPD_08_refl, EBRY_08_refl, EBRY_12, EAPD_01_refl, EAPD_11, EBRY_05_refl, EBRY_07_refl, EATJ_10, EAPD_08, EAPD_13, EAPD_07_refl, EATJ_12, EATJ_07, EAPD_06_refl, EBRY_10, EAPD_07, EATJ_06, EBRY_09, EAPD_05, EAPD_06, EBRY_03_refl, EAPD_15_refl, EAPD_05_refl, EAPD_02, EATJ_06_refl, EATJ_04, EBRY_02, EBRY_15, EBRY_04_refl, EAPD_03, EBRY_14, EATJ_01_refl, EBRY_01, EAPD_12, EAPD_10, EBRY_08, EBRY_11, EATJ_09, EBRY_06, EATJ_14, EAPD_01, EBRY_03, EAPD_17_refl, EATJ_03, EBRY_05, EATJ_05, EAPD_09, EATJ_14_refl, EAPD_16, EBRY_13, EATJ_13, EAPD_15, EATJ_15, EATJ_02, EBRY_17, EBRY_04, EAPD_17, EAPD_12_refl, EBRY_07, EATJ_16_refl, EATJ_17, EBRY_01_refl, EATJ_07_refl, EBRY_16, EBRY_02_refl, EATJ_09_refl, EATJ_02_refl, EBRY_16_refl, EAPD_02_refl, EAPD_14_refl, EAPD_09_refl, EATJ_03_refl, EAPD_03_refl, EATJ_11, EATJ_04_refl, EAPD_04, EAPD_14, EAPD_04_refl, EATJ_08_refl, EATJ_16, EAPD_16_refl, EATJ_08, EATJ_17_refl, EBRY_17_refl, EBRY_14_refl, EATJ_01, EBRY_06_refl, EATJ_05_refl, 
#5: EcalHitsEE has 2 ROU names:
EFRY_refl, EFRY, 
#6: EcalHitsES has 2 ROU names:
SFSY, SFSX, 
#7: HcalHits has 135 ROU names:
FibreBundle13, FibreBundle1, FibreBundle7, FibreBundle2, FibreBundle4, FibreBundle6, FibreBundle8, FibreBundle10, FibreBundle12, VcalElecCathode, VcalFibreBundleR1, VcalFibreBundleR3, VcalFibreBundleR5, VcalFibreBundleR12, VcalFibreBundleR4, VcalFibreBundleR8, VcalFibreBundleL0, FibreBundle5, VcalFibreBundleL2, VcalFibreBundleR10, VcalFibreBundleL6, VcalFibreBundleL8, VcalFibreBundleL10, VcalFibreBundleL1, VcalFibreBundleL7, VcalFibreBundleL11, HVQX, HTS1_T6_S, HTS1_T6, HTS1C_T6, HTS1_T5_S, HTS1C_T5, FibreBundle9, HTS1_T4_S, VcalFibreBundleR7, HTS1_T4, HTS1_T3_S, HTS1_T3, HTS1C_T2, HTS1_T1, HTS1C_T1, HTS0_T5, HEScintillatorPart0Layer00Phi1, HBScintillatorLayer8In2, HEScintillatorPart5Layer16Phi0, HBScintillatorLayer14In1, HBScintillatorLayer13In1, VcalFibreBundleR6, HBScintillatorLayer15In1, HBScintillatorLayer0In2, HBScintillatorLayer11In2, HTS1_T2, HBScintillatorLayer13In2, HBScintillatorLayer9In1, HBScintillatorLayer2In2, HBScintillatorLayer2In1, VcalFibreBundleL4, HBScintillatorLayer8In1, HBScintillatorLayer7In1, HBScintillatorLayer12In2, HBScintillatorLayer3In1, HBScintillatorLayer7In2, HEScintillatorPart4Layer07Phi1, HEScintillatorPart4Layer12Phi0, HBScintillatorLayer3In2, VcalFibreBundleL3, HBScintillatorLayer10In2, HTS1_T5, HEScintillatorPart1Layer00Phi0, HBScintillatorLayer4In1, HBScintillatorLayer5In1, HBScintillatorLayer14In2, HEScintillatorPart3Layer06Phi0, HBScintillatorLayer6In2, HEScintillatorPart5Layer18Phi0, HTS1C_T4, HBScintillatorLayer6In1, VcalFibreBundleL5, HEScintillatorPart2Layer01Phi1, HBScintillatorLayer1In2, HBScintillatorLayer10In1, HBScintillatorLayer4In2, HEScintillatorPart5Layer13Phi0, HEScintillatorPart1Layer00Phi1, HEScintillatorPart2Layer01Phi0, HEScintillatorPart4Layer08Phi1, HEScintillatorPart0Layer00Phi0, HEScintillatorPart5Layer14Phi1, HEScintillatorPart3Layer02Phi1, VcalFibreBundleR2, HEScintillatorPart4Layer09Phi1, HBScintillatorLayer1In1, HEScintillatorPart3Layer03Phi0, HEScintillatorPart3Layer05Phi0, FibreBundle11, HEScintillatorPart3Layer05Phi1, HEScintillatorPart3Layer06Phi1, HEScintillatorPart4Layer07Phi0, VcalFibreBundleR0, HTS1C_T3, HEScintillatorPart4Layer08Phi0, HBScintillatorLayer9In2, HBScintillatorLayer16In2, HTS0_T4, HEScintillatorPart4Layer09Phi0, HBScintillatorLayer5In2, HEScintillatorPart5Layer15Phi1, HEScintillatorPart4Layer10Phi0, HEScintillatorPart3Layer04Phi0, HEScintillatorPart5Layer13Phi1, FibreBundle3, HBScintillatorLayer16In1, HEScintillatorPart3Layer04Phi1, HEScintillatorPart4Layer10Phi1, VcalFibreBundleL9, HBScintillatorLayer11In1, HTS0_T2, HEScintillatorPart4Layer11Phi0, HEScintillatorPart4Layer11Phi1, HBScintillatorLayer15In2, HEScintillatorPart4Layer12Phi1, HTS0_T1, HEScintillatorPart3Layer03Phi1, HEScintillatorPart5Layer14Phi0, HBScintillatorLayer0In1, HEScintillatorPart5Layer15Phi0, HBScintillatorLayer12In1, HEScintillatorPart5Layer17Phi0, HEScintillatorPart3Layer02Phi0, HEScintillatorPart5Layer16Phi1, HEScintillatorPart5Layer17Phi1, VcalFibreBundleR9, HTS0_T6, HEScintillatorPart5Layer18Phi1, HTS0_T3, 
#8: MuonCSCHits has 20 ROU names:
ME32_ActiveGasVol_refl, ME31_ActiveGasVol_refl, ME22_ActiveGasVol_refl, ME21_ActiveGasVol_refl, ME21_ActiveGasVol, ME13_ActiveGasVol, ME11_ActiveGasVol, ME32_ActiveGasVol, ME31_ActiveGasVol, ME12_ActiveGasVol, ME1A_ActiveGasVol, ME42_ActiveGasVol, ME13_ActiveGasVol_refl, ME42_ActiveGasVol_refl, ME11_ActiveGasVol_refl, ME22_ActiveGasVol, ME41_ActiveGasVol, ME1A_ActiveGasVol_refl, ME12_ActiveGasVol_refl, ME41_ActiveGasVol_refl, 
#9: MuonDTHits has 5 ROU names:
MB3SLZGas, MB2SLZGas, MBChimSLPhiGas, MBSLPhiGas, MB1SLZGas, 
#10: MuonGEMHits has 16 ROU names:
GHA118, GHA114, GHA111, GHA108, GHA117, GHA107, GHA115, GHA113, GHA102, GHA103, GHA116, GHA112, GHA101, GHA105, GHA106, GHA104, 
#11: MuonRPCHits has 55 ROU names:
REF2, REF1, REE3, REE2, REC3, REB3, REB2, MB4BigChimRPC_GasLeft, MB4TopChimRPC_GasLeft, MB4BottomRPC_GasRight, MB4BottomRPC_GasLeft, MB4FeetRPC_GasRight, MB23RPC_IGasMiddle, MB22RPC_IGasLeft, MB22RPC_OGasRight, MB4TopRPC_GasLeft, MB23RPC_IGasRight, MB22RPC_IGasRight, REE1, MB2ChimRPC_IGasRight, MB3ChimRPC_GasRight, MB23RPC_IGasLeft, MB1RPC_IGasRight, REC1, MB4TopChimRPC_GasRight, MB1RPC_OGasRight, MB1RPC_IGasLeft, MB23RPC_OGasRight, MB1RPC_OGasLeft, MB4TopRPC_GasRight, REB1, MB2ChimRPC_IGasMiddle, MB1ChimRPC_OGasRight, MB4SmallRPC_SmallerGasRight, MB1ChimRPC_IGasLeft, MB22RPC_OGasLeft, MB1ChimRPC_OGasLeft, MB23RPC_OGasMiddle, MB4BigChimRPC_GasRight, MB2ChimRPC_OGasRight, MB2ChimRPC_IGasLeft, MB23RPC_OGasLeft, REC2, MB3RPC_GasLeft, MB2ChimRPC_OGasLeft, MB4SmallRPC_BiggerGasRight, MB1ChimRPC_IGasRight, MB3RPC_GasRight, MB3ChimRPC_GasLeft, MB4RPC_GasLeft, MB4RPC_GasRight, MB4SmallRPC_SmallerGasLeft, REF3, MB4SmallRPC_BiggerGasLeft, MB4FeetRPC_GasLeft, 
#12: TrackerHitsPixelBarrel has 4 ROU names:
PixelBarrelActiveFull3, PixelBarrelActiveFull0, PixelBarrelActiveFull2, PixelBarrelActiveFull1, 
#13: TrackerHitsPixelEndcap has 1 ROU names:
PixelForwardSensor, 
#14: TrackerHitsTEC has 10 ROU names:
TECModule6RphiActive, TECModule5RphiActive, TECModule4StereoActive, TECModule4RphiActive, TECModule0StereoActive, TECModule1RphiActive, TECModule0RphiActive, TECModule2RphiActive, TECModule1StereoActive, TECModule3RphiActive, 
#15: TrackerHitsTIB has 3 ROU names:
TIBActiveRphi2, TIBActiveRphi0, TIBActiveSter0, 
#16: TrackerHitsTID has 5 ROU names:
TIDModule2RphiActive, TIDModule1RphiActive, TIDModule0RphiActive, TIDModule1StereoActive, TIDModule0StereoActive, 
#17: TrackerHitsTOB has 4 ROU names:
TOBActiveRphi4, TOBActiveRphi2, TOBActiveRphi0, TOBActiveSter0, 
#18: ZDCHITS has 2 ROU names:
ZDC_EMFiber, ZDC_HadFiber, 


========== Here are the accessors =================

ClassName:BSCSensitiveDetector
       RedoutName:BSCHits
              LogicalName:BSCPadActive
              LogicalName:BSCBottomTrapezoid
              LogicalName:BSC2Pad
              LogicalName:BSCTopTrapezoid
ClassName:CaloTrkProcessing
       RedoutName:CaloHitsTk
              LogicalName:CALO
ClassName:CastorSensitiveDetector
       RedoutName:CastorFI
              LogicalName:C4HF
              LogicalName:C3HF
              LogicalName:C4EF
              LogicalName:CAST
              LogicalName:C3EF
ClassName:EcalSensitiveDetector
       RedoutName:EcalHitsES
              LogicalName:SFSY
              LogicalName:SFSX
       RedoutName:EcalHitsEB
              LogicalName:EATJ_15_refl
              LogicalName:EAPD_13_refl
              LogicalName:EATJ_13_refl
              LogicalName:EATJ_12_refl
              LogicalName:EBRY_12_refl
              LogicalName:EAPD_11_refl
              LogicalName:EBRY_15_refl
              LogicalName:EATJ_11_refl
              LogicalName:EBRY_11_refl
              LogicalName:EAPD_10_refl
              LogicalName:EATJ_10_refl
              LogicalName:EBRY_10_refl
              LogicalName:EBRY_09_refl
              LogicalName:EBRY_13_refl
              LogicalName:EAPD_08_refl
              LogicalName:EBRY_08_refl
              LogicalName:EBRY_12
              LogicalName:EAPD_01_refl
              LogicalName:EAPD_11
              LogicalName:EBRY_05_refl
              LogicalName:EBRY_07_refl
              LogicalName:EATJ_10
              LogicalName:EAPD_08
              LogicalName:EAPD_13
              LogicalName:EAPD_07_refl
              LogicalName:EATJ_12
              LogicalName:EATJ_07
              LogicalName:EAPD_06_refl
              LogicalName:EBRY_10
              LogicalName:EAPD_07
              LogicalName:EATJ_06
              LogicalName:EBRY_09
              LogicalName:EAPD_05
              LogicalName:EAPD_06
              LogicalName:EBRY_03_refl
              LogicalName:EAPD_15_refl
              LogicalName:EAPD_05_refl
              LogicalName:EAPD_02
              LogicalName:EATJ_06_refl
              LogicalName:EATJ_04
              LogicalName:EBRY_02
              LogicalName:EBRY_15
              LogicalName:EBRY_04_refl
              LogicalName:EAPD_03
              LogicalName:EBRY_14
              LogicalName:EATJ_01_refl
              LogicalName:EBRY_01
              LogicalName:EAPD_12
              LogicalName:EAPD_10
              LogicalName:EBRY_08
              LogicalName:EBRY_11
              LogicalName:EATJ_09
              LogicalName:EBRY_06
              LogicalName:EATJ_14
              LogicalName:EAPD_01
              LogicalName:EBRY_03
              LogicalName:EAPD_17_refl
              LogicalName:EATJ_03
              LogicalName:EBRY_05
              LogicalName:EATJ_05
              LogicalName:EAPD_09
              LogicalName:EATJ_14_refl
              LogicalName:EAPD_16
              LogicalName:EBRY_13
              LogicalName:EATJ_13
              LogicalName:EAPD_15
              LogicalName:EATJ_15
              LogicalName:EATJ_02
              LogicalName:EBRY_17
              LogicalName:EBRY_04
              LogicalName:EAPD_17
              LogicalName:EAPD_12_refl
              LogicalName:EBRY_07
              LogicalName:EATJ_16_refl
              LogicalName:EATJ_17
              LogicalName:EBRY_01_refl
              LogicalName:EATJ_07_refl
              LogicalName:EBRY_16
              LogicalName:EBRY_02_refl
              LogicalName:EATJ_09_refl
              LogicalName:EATJ_02_refl
              LogicalName:EBRY_16_refl
              LogicalName:EAPD_02_refl
              LogicalName:EAPD_14_refl
              LogicalName:EAPD_09_refl
              LogicalName:EATJ_03_refl
              LogicalName:EAPD_03_refl
              LogicalName:EATJ_11
              LogicalName:EATJ_04_refl
              LogicalName:EAPD_04
              LogicalName:EAPD_04
              LogicalName:EAPD_14
              LogicalName:EAPD_04_refl
              LogicalName:EATJ_08_refl
              LogicalName:EATJ_16
              LogicalName:EAPD_16_refl
              LogicalName:EATJ_08
              LogicalName:EATJ_17_refl
              LogicalName:EBRY_17_refl
              LogicalName:EBRY_14_refl
              LogicalName:EATJ_01
              LogicalName:EBRY_06_refl
              LogicalName:EATJ_05_refl
       RedoutName:EcalHitsEE
              LogicalName:EFRY_refl
              LogicalName:EFRY
ClassName:HcalSensitiveDetector
       RedoutName:HcalHits
              LogicalName:FibreBundle13
              LogicalName:FibreBundle1
              LogicalName:FibreBundle7
              LogicalName:FibreBundle2
              LogicalName:FibreBundle4
              LogicalName:FibreBundle6
              LogicalName:FibreBundle8
              LogicalName:FibreBundle10
              LogicalName:FibreBundle12
              LogicalName:VcalElecCathode
              LogicalName:VcalFibreBundleR1
              LogicalName:VcalFibreBundleR3
              LogicalName:VcalFibreBundleR5
              LogicalName:VcalFibreBundleR12
              LogicalName:VcalFibreBundleR4
              LogicalName:VcalFibreBundleR8
              LogicalName:VcalFibreBundleL0
              LogicalName:FibreBundle5
              LogicalName:VcalFibreBundleL2
              LogicalName:VcalFibreBundleR10
              LogicalName:VcalFibreBundleL6
              LogicalName:VcalFibreBundleL8
              LogicalName:VcalFibreBundleL10
              LogicalName:VcalFibreBundleL1
              LogicalName:VcalFibreBundleL7
              LogicalName:VcalFibreBundleL11
              LogicalName:HVQX
              LogicalName:HTS1_T6_S
              LogicalName:HTS1_T6
              LogicalName:HTS1C_T6
              LogicalName:HTS1_T5_S
              LogicalName:HTS1C_T5
              LogicalName:FibreBundle9
              LogicalName:HTS1_T4_S
              LogicalName:VcalFibreBundleR7
              LogicalName:HTS1_T4
              LogicalName:HTS1_T3_S
              LogicalName:HTS1_T3
              LogicalName:HTS1C_T2
              LogicalName:HTS1_T1
              LogicalName:HTS1C_T1
              LogicalName:HTS0_T5
              LogicalName:HEScintillatorPart0Layer00Phi1
              LogicalName:HBScintillatorLayer8In2
              LogicalName:HEScintillatorPart5Layer16Phi0
              LogicalName:HBScintillatorLayer14In1
              LogicalName:HBScintillatorLayer13In1
              LogicalName:VcalFibreBundleR6
              LogicalName:HBScintillatorLayer15In1
              LogicalName:HBScintillatorLayer0In2
              LogicalName:HBScintillatorLayer11In2
              LogicalName:HTS1_T2
              LogicalName:HBScintillatorLayer13In2
              LogicalName:HBScintillatorLayer9In1
              LogicalName:HBScintillatorLayer2In2
              LogicalName:HBScintillatorLayer2In1
              LogicalName:VcalFibreBundleL4
              LogicalName:HBScintillatorLayer8In1
              LogicalName:HBScintillatorLayer7In1
              LogicalName:HBScintillatorLayer12In2
              LogicalName:HBScintillatorLayer3In1
              LogicalName:HBScintillatorLayer7In2
              LogicalName:HEScintillatorPart4Layer07Phi1
              LogicalName:HEScintillatorPart4Layer12Phi0
              LogicalName:HBScintillatorLayer3In2
              LogicalName:VcalFibreBundleL3
              LogicalName:HBScintillatorLayer10In2
              LogicalName:HTS1_T5
              LogicalName:HEScintillatorPart1Layer00Phi0
              LogicalName:HBScintillatorLayer4In1
              LogicalName:HBScintillatorLayer5In1
              LogicalName:HBScintillatorLayer14In2
              LogicalName:HEScintillatorPart3Layer06Phi0
              LogicalName:HBScintillatorLayer6In2
              LogicalName:HEScintillatorPart5Layer18Phi0
              LogicalName:HTS1C_T4
              LogicalName:HBScintillatorLayer6In1
              LogicalName:VcalFibreBundleL5
              LogicalName:HEScintillatorPart2Layer01Phi1
              LogicalName:HBScintillatorLayer1In2
              LogicalName:HBScintillatorLayer10In1
              LogicalName:HBScintillatorLayer4In2
              LogicalName:HEScintillatorPart5Layer13Phi0
              LogicalName:HEScintillatorPart1Layer00Phi1
              LogicalName:HEScintillatorPart2Layer01Phi0
              LogicalName:HEScintillatorPart4Layer08Phi1
              LogicalName:HEScintillatorPart0Layer00Phi0
              LogicalName:HEScintillatorPart5Layer14Phi1
              LogicalName:HEScintillatorPart3Layer02Phi1
              LogicalName:VcalFibreBundleR2
              LogicalName:HEScintillatorPart4Layer09Phi1
              LogicalName:HBScintillatorLayer1In1
              LogicalName:HEScintillatorPart3Layer03Phi0
              LogicalName:HEScintillatorPart3Layer05Phi0
              LogicalName:FibreBundle11
              LogicalName:HEScintillatorPart3Layer05Phi1
              LogicalName:HEScintillatorPart3Layer06Phi1
              LogicalName:HEScintillatorPart4Layer07Phi0
              LogicalName:VcalFibreBundleR0
              LogicalName:HTS1C_T3
              LogicalName:HEScintillatorPart4Layer08Phi0
              LogicalName:HBScintillatorLayer9In2
              LogicalName:HBScintillatorLayer16In2
              LogicalName:HTS0_T4
              LogicalName:HEScintillatorPart4Layer09Phi0
              LogicalName:HBScintillatorLayer5In2
              LogicalName:HEScintillatorPart5Layer15Phi1
              LogicalName:HEScintillatorPart4Layer10Phi0
              LogicalName:HEScintillatorPart3Layer04Phi0
              LogicalName:HEScintillatorPart5Layer13Phi1
              LogicalName:FibreBundle3
              LogicalName:HBScintillatorLayer16In1
              LogicalName:HEScintillatorPart3Layer04Phi1
              LogicalName:HEScintillatorPart4Layer10Phi1
              LogicalName:VcalFibreBundleL9
              LogicalName:HBScintillatorLayer11In1
              LogicalName:HTS0_T2
              LogicalName:HEScintillatorPart4Layer11Phi0
              LogicalName:HEScintillatorPart4Layer11Phi1
              LogicalName:HBScintillatorLayer15In2
              LogicalName:HEScintillatorPart4Layer12Phi1
              LogicalName:HTS0_T1
              LogicalName:HEScintillatorPart3Layer03Phi1
              LogicalName:HEScintillatorPart5Layer14Phi0
              LogicalName:HBScintillatorLayer0In1
              LogicalName:HEScintillatorPart5Layer15Phi0
              LogicalName:HBScintillatorLayer12In1
              LogicalName:HEScintillatorPart5Layer17Phi0
              LogicalName:HEScintillatorPart3Layer02Phi0
              LogicalName:HEScintillatorPart5Layer16Phi1
              LogicalName:HEScintillatorPart5Layer17Phi1
              LogicalName:VcalFibreBundleR9
              LogicalName:HTS0_T6
              LogicalName:HEScintillatorPart5Layer18Phi1
              LogicalName:HTS0_T3
ClassName:MuonSensitiveDetector
       RedoutName:MuonGEMHits
              LogicalName:GHA118
              LogicalName:GHA114
              LogicalName:GHA111
              LogicalName:GHA108
              LogicalName:GHA117
              LogicalName:GHA107
              LogicalName:GHA115
              LogicalName:GHA113
              LogicalName:GHA102
              LogicalName:GHA103
              LogicalName:GHA116
              LogicalName:GHA112
              LogicalName:GHA101
              LogicalName:GHA105
              LogicalName:GHA106
              LogicalName:GHA104
       RedoutName:MuonCSCHits
              LogicalName:ME32_ActiveGasVol_refl
              LogicalName:ME31_ActiveGasVol_refl
              LogicalName:ME22_ActiveGasVol_refl
              LogicalName:ME21_ActiveGasVol_refl
              LogicalName:ME21_ActiveGasVol
              LogicalName:ME13_ActiveGasVol
              LogicalName:ME11_ActiveGasVol
              LogicalName:ME32_ActiveGasVol
              LogicalName:ME31_ActiveGasVol
              LogicalName:ME12_ActiveGasVol
              LogicalName:ME1A_ActiveGasVol
              LogicalName:ME42_ActiveGasVol
              LogicalName:ME13_ActiveGasVol_refl
              LogicalName:ME42_ActiveGasVol_refl
              LogicalName:ME11_ActiveGasVol_refl
              LogicalName:ME22_ActiveGasVol
              LogicalName:ME41_ActiveGasVol
              LogicalName:ME1A_ActiveGasVol_refl
              LogicalName:ME12_ActiveGasVol_refl
              LogicalName:ME41_ActiveGasVol_refl
       RedoutName:MuonRPCHits
              LogicalName:REF2
              LogicalName:REF1
              LogicalName:REE3
              LogicalName:REE2
              LogicalName:REC3
              LogicalName:REB3
              LogicalName:REB2
              LogicalName:MB4BigChimRPC_GasLeft
              LogicalName:MB4TopChimRPC_GasLeft
              LogicalName:MB4BottomRPC_GasRight
              LogicalName:MB4BottomRPC_GasLeft
              LogicalName:MB4FeetRPC_GasRight
              LogicalName:MB23RPC_IGasMiddle
              LogicalName:MB22RPC_IGasLeft
              LogicalName:MB22RPC_OGasRight
              LogicalName:MB4TopRPC_GasLeft
              LogicalName:MB23RPC_IGasRight
              LogicalName:MB22RPC_IGasRight
              LogicalName:REE1
              LogicalName:MB2ChimRPC_IGasRight
              LogicalName:MB3ChimRPC_GasRight
              LogicalName:MB23RPC_IGasLeft
              LogicalName:MB1RPC_IGasRight
              LogicalName:REC1
              LogicalName:MB4TopChimRPC_GasRight
              LogicalName:MB1RPC_OGasRight
              LogicalName:MB1RPC_IGasLeft
              LogicalName:MB23RPC_OGasRight
              LogicalName:MB1RPC_OGasLeft
              LogicalName:MB4TopRPC_GasRight
              LogicalName:REB1
              LogicalName:MB2ChimRPC_IGasMiddle
              LogicalName:MB1ChimRPC_OGasRight
              LogicalName:MB4SmallRPC_SmallerGasRight
              LogicalName:MB1ChimRPC_IGasLeft
              LogicalName:MB22RPC_OGasLeft
              LogicalName:MB1ChimRPC_OGasLeft
              LogicalName:MB23RPC_OGasMiddle
              LogicalName:MB4BigChimRPC_GasRight
              LogicalName:MB2ChimRPC_OGasRight
              LogicalName:MB2ChimRPC_IGasLeft
              LogicalName:MB23RPC_OGasLeft
              LogicalName:REC2
              LogicalName:MB3RPC_GasLeft
              LogicalName:MB2ChimRPC_OGasLeft
              LogicalName:MB4SmallRPC_BiggerGasRight
              LogicalName:MB1ChimRPC_IGasRight
              LogicalName:MB3RPC_GasRight
              LogicalName:MB3ChimRPC_GasLeft
              LogicalName:MB4RPC_GasLeft
              LogicalName:MB4RPC_GasRight
              LogicalName:MB4SmallRPC_SmallerGasLeft
              LogicalName:REF3
              LogicalName:MB4SmallRPC_BiggerGasLeft
              LogicalName:MB4FeetRPC_GasLeft
       RedoutName:MuonDTHits
              LogicalName:MB3SLZGas
              LogicalName:MB2SLZGas
              LogicalName:MBChimSLPhiGas
              LogicalName:MBSLPhiGas
              LogicalName:MB1SLZGas
ClassName:TkAccumulatingSensitiveDetector
       RedoutName:TrackerHitsTEC
              LogicalName:TECModule6RphiActive
              LogicalName:TECModule5RphiActive
              LogicalName:TECModule4StereoActive
              LogicalName:TECModule4RphiActive
              LogicalName:TECModule0StereoActive
              LogicalName:TECModule1RphiActive
              LogicalName:TECModule0RphiActive
              LogicalName:TECModule2RphiActive
              LogicalName:TECModule1StereoActive
              LogicalName:TECModule3RphiActive
       RedoutName:TrackerHitsTIB
              LogicalName:TIBActiveRphi2
              LogicalName:TIBActiveRphi0
              LogicalName:TIBActiveSter0
       RedoutName:TrackerHitsPixelEndcap
              LogicalName:PixelForwardSensor
       RedoutName:TrackerHitsTOB
              LogicalName:TOBActiveRphi4
              LogicalName:TOBActiveRphi2
              LogicalName:TOBActiveRphi0
              LogicalName:TOBActiveSter0
       RedoutName:TrackerHitsTID
              LogicalName:TIDModule2RphiActive
              LogicalName:TIDModule1RphiActive
              LogicalName:TIDModule0RphiActive
              LogicalName:TIDModule1StereoActive
              LogicalName:TIDModule0StereoActive
       RedoutName:TrackerHitsPixelBarrel
              LogicalName:PixelBarrelActiveFull3
              LogicalName:PixelBarrelActiveFull0
              LogicalName:PixelBarrelActiveFull2
              LogicalName:PixelBarrelActiveFull1
ClassName:ZdcSensitiveDetector
       RedoutName:ZDCHITS
              LogicalName:ZDC_EMFiber
              LogicalName:ZDC_HadFiber

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jul 24, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27598/11027

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4Core/Geometry
SimG4Core/SensitiveDetector

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Jul 24, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1617/console Started: 2019/07/24 19:19

@cmsbuild
Copy link
Contributor

+1
Tested at: 995b8c3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da45ef/1617/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da45ef/1617/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2628546
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2628228
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@civanch
Copy link
Contributor

civanch commented Jul 24, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ce37115 into cms-sw:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocos fabiocos fabiocos left review comments

@civanch civanch civanch left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ianna @cmsbuild @civanch @fabiocos