Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Pixel Charge Reweighting for phase-0 detector (2016 only) #27600

Merged
merged 7 commits into from Jul 30, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 24, 2019

PR description:

In the scope of the preparations for the 2016 Ultra-Legacy MC campaigns, when looking at the data charge profiles, we have reached the conclusion that the radiation damage accumulated by the Phase-0 detector justifies the activation of the pixel cluster charge re-weighting (full details on the study of the radiation damage is presented here: here).
This feature was up to now nominally switched off for the the Phase-0 detector and it is hereby activated by means of the era mechanism.
A new modifier Configuration/Eras/python/Modifier_pixel_2016_cff.py is introduced and used in the definition of the Era_Run2_2016 to selectively switch on the feature only for 2016 which is targeted by the Ultra-Legacy.
An appropriate set of 2D template conditions for the radiation damage model has been derived together with update CPE conditions (Simulation Lorentz Angle, Lorentz Angle offset calibration, empry Lorentz Angle widths, generic errors and 1D templates), using the third IOV of the data conditions as an approximation of the "average" radiation damage in 2016.
They are proposed in this PR, by updating several autoCond keys with candidate Global Tags:

N.B.: in the design MC case only the 2D template tags are changed using the same payload both at the numerator and denominator label, resulting in no re-weigthing applied (design is assumed to be unirradiated).
If AlCa/DB can make these full-fledged Global Tags I will be gladly updating the autoCond file.

PR validation:

The PR passes standard tests (addOnTests and runTheMatrix.py -l limited -t 4 -j 8.

Additionally the effect of the charge re-weighting has been tested in simulation by comparing the pixel charge profiles vs depth with two 2016 runs 278240 & 278308 ( falling into IOV 3 of the data CPE conditions) and the reference MC without re-weighting.
The comparison is shown here

image

Post-reweighting DATA and MC profiles are found in satisfactory agreement.

if this PR is a backport please specify the original PR:

This PR is not a backport
cc:
@tsusa @tvami @leaca

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27600/11029

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/AlCa
Configuration/Eras
SimGeneral/MixingModule

@civanch, @christopheralanwest, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1619/console Started: 2019/07/24 20:34

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3e5e4/1619/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4155 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2628546
  • DQMHistoTests: Total failures: 19562
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2608667
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.016 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 25202.0 ): -0.016 KiB SiStrip/MechanicalView
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1690/console Started: 2019/07/29 20:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3e5e4/1690/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4196 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2628546
  • DQMHistoTests: Total failures: 19879
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2608350
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.016 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 25202.0 ): -0.016 KiB SiStrip/MechanicalView
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@christopheralanwest
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Jul 30, 2019

+1

@kpedro88
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit fdec8cf into cms-sw:master Jul 30, 2019
@fabiocos
Copy link
Contributor

+operations

the update is coherent with the purpose of the PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants