-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate Pixel Charge Reweighting for phase-0 detector (2016 only) #27600
Activate Pixel Charge Reweighting for phase-0 detector (2016 only) #27600
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27600/11029
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Configuration/AlCa @civanch, @christopheralanwest, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1 |
merge |
+operations the update is coherent with the purpose of the PR |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
In the scope of the preparations for the 2016 Ultra-Legacy MC campaigns, when looking at the data charge profiles, we have reached the conclusion that the radiation damage accumulated by the Phase-0 detector justifies the activation of the pixel cluster charge re-weighting (full details on the study of the radiation damage is presented here: here).
This feature was up to now nominally switched off for the the Phase-0 detector and it is hereby activated by means of the era mechanism.
A new modifier
Configuration/Eras/python/Modifier_pixel_2016_cff.py
is introduced and used in the definition of theEra_Run2_2016
to selectively switch on the feature only for 2016 which is targeted by the Ultra-Legacy.An appropriate set of 2D template conditions for the radiation damage model has been derived together with update CPE conditions (Simulation Lorentz Angle, Lorentz Angle offset calibration, empry Lorentz Angle widths, generic errors and 1D templates), using the third IOV of the data conditions as an approximation of the "average" radiation damage in 2016.
They are proposed in this PR, by updating several
autoCond
keys with candidate Global Tags:run2_design
: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_design_v1/110X_mcRun2_design_v2run2_mc
: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_asymptotic_v1/110X_mcRun2_asymptotic_v2run2_mc_cosmics
: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2cosmics_startup_deco_v1/110X_mcRun2cosmics_startup_deco_v2run2_mc_pa
: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun2_pA_v1/110X_mcRun2_pA_v2N.B.: in the design MC case only the 2D template tags are changed using the same payload both at the
numerator
anddenominator
label, resulting in no re-weigthing applied (design is assumed to be unirradiated).If AlCa/DB can make these full-fledged Global Tags I will be gladly updating the autoCond file.PR validation:
The PR passes standard tests (
addOnTests
andrunTheMatrix.py -l limited -t 4 -j 8
.Additionally the effect of the charge re-weighting has been tested in simulation by comparing the pixel charge profiles vs depth with two 2016 runs 278240 & 278308 ( falling into IOV 3 of the data CPE conditions) and the reference MC without re-weighting.
The comparison is shown here
Post-reweighting DATA and MC profiles are found in satisfactory agreement.
if this PR is a backport please specify the original PR:
This PR is not a backport
cc:
@tsusa @tvami @leaca