Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECAL conditions to provide correct reference for 2016 and 2018 UL #27604

Merged
merged 1 commit into from Jul 27, 2019

Conversation

christopheralanwest
Copy link
Contributor

@christopheralanwest christopheralanwest commented Jul 24, 2019

PR description:

This PR updates the channel status and PF RecHit thresholds for the ECAL in order to have a sensible baseline with which to compare the completed 2016 and 2018 UL. The fixes to these conditions are described in the links below:

https://indico.cern.ch/event/834561/#26-fixes-in-data-reference-gt
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4177.html

The GT diffs are below:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_v2/110X_dataRun2_v1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_v2/110X_dataRun2_relval_v1

Only 2016 and earlier data should be affected by the EcalPFRecHitThresholds update; for a discussion of the impact on Run-1 data, see the Hypernews subthread. For the channel status update, only 2018 data should be affected.

This PR will be backported to 10_6_X.

PR validation:

See talk at 22 Jul 2019 AlCaDB meeting for details of the tag content.

A technical test has been performed: runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR:

This PR is not a backport.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27604/11041

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1625/console Started: 2019/07/25 01:07

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a67556/1625/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5500 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2628546
  • DQMHistoTests: Total failures: 502
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2627719
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.016 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 136.731 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 4.53 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • The PR comparison tests show the expected differences. The differences are only in ECAL or ECAL-dependent quantities and only in Run-1, 2016 and 2018 data workflows. The differences in 2018 workflows are very small as only the EcalChannelStatus is updated.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6459f19 into cms-sw:master Jul 27, 2019
@christopheralanwest christopheralanwest deleted the alca-fix-ecal-ul-ref branch August 21, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants