Modernized MuonDetLayerGeometryESProducer #27602
Conversation
-Added consumes and ESGetToken -Added fillDescription -Merged header and source files and remvoed SealModule
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27602/11038
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoMuon/DetLayers @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
|
||
| void MuonDetLayerGeometryESProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) { | ||
| edm::ParameterSetDescription desc; | ||
| //no parameters are used |
There was a problem hiding this comment.
Is fillDescriptions still needed/useful, then?
There was a problem hiding this comment.
Yes. This tells the framework that no parameters are allowed (which is correct for this module). If one does not provide a fillDescriptions, that tells the framework any parameters are allowed.
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
part of #26748 |
PR description:
-Added consumes and ESGetToken
-Added fillDescription
-Merged header and source files and remvoed SealModule
PR validation:
Code compiles.
The changes are technical and should not affect results.