Run3-hcx213 Make HcalSimParameter class to handle simulation parameters for HCAL #27609

bsunanda · 2019-07-25T14:19:40Z

PR description:

Handle all simulation parameters of Hcal coming from CompactView in a geometry class so that Simulation class will not require handling CompactView

PR validation:

Currently it does not affect any workflow. Subsequent ones utilizing these changes will. So the changes are tested with standalone tests

if this PR is a backport please specify the original PR:

Nothing special

cmsbuild · 2019-07-25T14:20:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-25T14:27:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27609/11050

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27609/11050/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27609/11050/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-07-25T14:30:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-25T14:36:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27609/11051

This PR adds an extra 20KB to repository

cmsbuild · 2019-07-25T14:36:54Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

CondFormats/GeometryObjects
Geometry/HcalCommonData

@civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

christopheralanwest · 2019-07-25T15:11:29Z

please test

cmsbuild · 2019-07-25T15:11:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1637/console Started: 2019/07/25 17:12

cmsbuild · 2019-07-25T16:20:34Z

-1

Tested at: 891bf1a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-962b1c/1637/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
7.3 step2

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step2_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

11624.0 step2

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

250202.181 step2

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Jul 25 18:14:54 2019-date Thu Jul 25 18:00:43 2019 s - exit: 16896
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Thu Jul 25 18:05:14 2019-date Thu Jul 25 18:00:48 2019 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Thu Jul 25 18:08:33 2019-date Thu Jul 25 18:00:50 2019 s - exit: 16896
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Thu Jul 25 18:05:13 2019-date Thu Jul 25 18:00:53 2019 s - exit: 16896
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Jul 25 18:08:19 2019-date Thu Jul 25 18:01:00 2019 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018_pp_on_AA --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Thu Jul 25 18:09:34 2019-date Thu Jul 25 18:01:02 2019 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Thu Jul 25 18:07:56 2019-date Thu Jul 25 18:01:07 2019 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Thu Jul 25 18:08:05 2019-date Thu Jul 25 18:01:11 2019 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Thu Jul 25 18:10:38 2019-date Thu Jul 25 18:05:15 2019 s - exit: 16896

cmsbuild · 2019-07-25T16:20:37Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-08-08T15:02:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1916/console Started: 2019/08/08 17:04

fabiocos · 2019-08-08T15:08:03Z

@bsunanda as far as I can see the PR looks ok, I will wait for the test and integrate it, @ggovi may have an expert look next week when he is back and possibly comment for further updates

cmsbuild · 2019-08-08T16:22:40Z

+1
Tested at: 680f958
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-962b1c/1916/summary.html

cmsbuild · 2019-08-08T16:22:44Z

Comparison job queued.

cmsbuild · 2019-08-08T17:59:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-962b1c/1916/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 2715989
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2715659
DQMHistoTests: Total skipped: 329
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

fabiocos · 2019-08-08T20:33:57Z

@cvuosalo @pohsun given the minimal nature of the adjustment (unrelated from the code) I take your previous signature as good.
@ggovi please check at your earliest convenience

fabiocos · 2019-08-08T20:34:02Z

+1

fabiocos · 2019-08-08T20:38:47Z

merge

cvuosalo · 2019-08-08T20:49:03Z

+1

ggovi · 2019-08-13T14:07:09Z

+1

christopheralanwest · 2019-08-13T22:24:51Z

+1

cmsbuild · 2019-08-13T22:25:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_11_0_X milestone Jul 25, 2019

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending geometry-pending orp-pending pending-signatures tests-pending labels Jul 25, 2019

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jul 25, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 25, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 25, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 25, 2019

cmsbuild added the tests-pending label Aug 8, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 8, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 8, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 8, 2019

cmsbuild added orp-approved and removed orp-pending labels Aug 8, 2019

cmsbuild merged commit 35b823e into cms-sw:master Aug 8, 2019

cmsbuild added geometry-approved and removed geometry-pending labels Aug 8, 2019

cmsbuild added db-approved and removed db-pending labels Aug 13, 2019

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Aug 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-hcx213 Make HcalSimParameter class to handle simulation parameters for HCAL #27609

Run3-hcx213 Make HcalSimParameter class to handle simulation parameters for HCAL #27609

bsunanda commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

christopheralanwest commented Jul 25, 2019

cmsbuild commented Jul 25, 2019 •

edited

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Aug 8, 2019 •

edited

fabiocos commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

fabiocos commented Aug 8, 2019

fabiocos commented Aug 8, 2019

fabiocos commented Aug 8, 2019

cvuosalo commented Aug 8, 2019

ggovi commented Aug 13, 2019

christopheralanwest commented Aug 13, 2019

cmsbuild commented Aug 13, 2019

Run3-hcx213 Make HcalSimParameter class to handle simulation parameters for HCAL #27609

Run3-hcx213 Make HcalSimParameter class to handle simulation parameters for HCAL #27609

Conversation

bsunanda commented Jul 25, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

christopheralanwest commented Jul 25, 2019

cmsbuild commented Jul 25, 2019 • edited

cmsbuild commented Jul 25, 2019

cmsbuild commented Jul 25, 2019

cmsbuild commented Aug 8, 2019 • edited

fabiocos commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

fabiocos commented Aug 8, 2019

fabiocos commented Aug 8, 2019

fabiocos commented Aug 8, 2019

cvuosalo commented Aug 8, 2019

ggovi commented Aug 13, 2019

christopheralanwest commented Aug 13, 2019

cmsbuild commented Aug 13, 2019

cmsbuild commented Jul 25, 2019 •

edited

cmsbuild commented Aug 8, 2019 •

edited