New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim37 Enable the useful analyzer to run in the same step as simulation #27612
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27612/11056
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimG4CMS/Calo @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda what is the plan here? To optionally add some of these new plugins in some test workflow? I would imagine this is not for production |
@fabiocos The analyzers are used in validating newer versions of Geant4. These are run in the Sim step. But with current biglib's this does not work if the analyzers stay in the test directory - that is why they are moved to plugins and now one can run the analyzers in the same step. It started happening in 10_6 (or may be even in 10_5). Only now we understand the reason of earlier crashes. So these analyzers will not be added in standard production runs but in testing newer Geant4 or even GeantV versions. |
+1 |
PR description:
Enable the useful analyzers in SimG4CMS/Calo to run in the same step as simulation
PR validation:
The crashes in earlier runs are removed. It is essentially rearrangement of files. The standard workflows are unaffected.
if this PR is a backport please specify the original PR:
Nothing special