-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consumes to ES modules in RecoLocalTracker/SiPixelRecHits #27614
Add consumes to ES modules in RecoLocalTracker/SiPixelRecHits #27614
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27614/11060
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoLocalTracker/SiPixelRecHits @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
adec148
to
fa864ee
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27614/11061
|
please test |
The tests are being triggered in jenkins. |
-1 Tested at: fa864ee You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/src/RecoLocalTracker/SiPixelRecHits/src/PixelCPEClusterRepair.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/src/RecoLocalTracker/SiPixelRecHits/src/PixelCPEBase.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/src/RecoLocalTracker/SiPixelRecHits/src/PixelCPEGeneric.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/src/RecoLocalTracker/SiPixelRecHits/src/VVIObj.cc In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/src/RecoLocalTracker/SiPixelRecHits/src/SealModules.cc:9:0: /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/poison/RecoLocalTracker/SiPixelRecHits/interface/PixelCPEGenericESProducer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. ^~~~~ In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/src/RecoLocalTracker/SiPixelRecHits/src/SealModules.cc:10:0: /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-25-1100/poison/RecoLocalTracker/SiPixelRecHits/interface/PixelCPETemplateRecoESProducer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27614/11082
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
PixelCPEGenericESProducer and PixelCPETemplateRecoESProducer may benefit from fillDescriptions at some point soon to get rid of the |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
part of #26748 |
PR description:
As part of the change, consolidated header and source files.
PR validation:
The code compiles.
This is only a technical change so should not change results.