DD4hep: Migrate Muon Algorithms to Geometry/MuonCommonData Package #27669

ianna · 2019-08-01T15:58:18Z

PR description:

Move Muon algorithms to Geometry/MuonCommonData package under dd4hep directory
Merge declaration and definition of the DD algorithms
The code is unchanged

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

ianna · 2019-08-01T15:58:39Z

please test

cmsbuild · 2019-08-01T16:00:44Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-01T16:06:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27669/11240

This PR adds an extra 16KB to repository

cmsbuild · 2019-08-01T16:06:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1778/console Started: 2019/08/01 18:07

cmsbuild · 2019-08-01T16:06:49Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-08-01T18:17:44Z

+1
Tested at: 389b250
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3f87c/1778/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Added consumes to EcalSeverityLevelESProducer #27643 @Dr15Jones: Added consumes to EcalSeverityLevelESProducer
Remove SiStripBadModuleFedErrESSource #27565 @pieterdavid: Remove SiStripBadModuleFedErrESSource
Updates to E(H)CalEnergy definitions for PF hadrons. #27550 @hatakeyamak: Updates to E(H)CalEnergy definitions for PF hadrons.
Added consumes to EcalNextToDeadChannelESProducer #27645 @Dr15Jones: Added consumes to EcalNextToDeadChannelESProducer
[Sim] Move the Dispatchable Container to the Geometry Package #27641 @ianna: [Sim] Move the Dispatchable Container to the Geometry Package
Enable Ecal DQM in Phase 2 workflows #27549 @tanmaymudholkar: Enable Ecal DQM in Phase 2 workflows
DD4Hep: Tracker DDPixPhase1FwdDiskAlgo Migration #27636 @vargasa: DD4Hep: Tracker DDPixPhase1FwdDiskAlgo Migration
SimPPS/PPSPixelDigiProducer package for PPS Full simulation #27559 @CTPPS: SimPPS/PPSPixelDigiProducer package for PPS Full simulation
DD4Hep: Fix XML variable references #27628 @vargasa: DD4Hep: Fix XML variable references
Add consumes to ES modules in RecoLocalTracker/SiPixelRecHits #27614 @Dr15Jones: Add consumes to ES modules in RecoLocalTracker/SiPixelRecHits
Run3-sim38 Enable plugins from the TB areas to work #27613 @bsunanda: Run3-sim38 Enable plugins from the TB areas to work
Bug fix for setRunNumberForEachLumi #27649 @wddgit: Bug fix for setRunNumberForEachLumi
MTV protection for samples without jets info #27611 @vberta: MTV protection for samples without jets info
DD4Hep: Tracker DDPixFwdDisk Algorithm #27627 @vargasa: DD4Hep: Tracker DDPixFwdDisk Algorithm

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3f87c/1778/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3f87c/1778/git-merge-result

cmsbuild · 2019-08-01T18:17:48Z

Comparison job queued.

cmsbuild · 2019-08-01T20:18:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3f87c/1778/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 27 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2484130
DQMHistoTests: Total failures: 32
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2483781
DQMHistoTests: Total skipped: 317
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 92592.151 KiB( 31 files compared)
DQMHistoSizes: changed ( 25.0,... ): 1843.433 KiB EcalDigisV/SelectiveReadout
DQMHistoSizes: changed ( 25.0,... ): -1139.741 KiB h2ChOcc
DQMHistoSizes: changed ( 25.0,... ): -47.427 KiB hIncompleteFRORateMap
DQMHistoSizes: changed ( 25.0,... ): -47.424 KiB hDroppedFRORateMap
DQMHistoSizes: changed ( 25.0,... ): -47.421 KiB hCompleteZSRate
DQMHistoSizes: changed ( 25.0,... ): -40.656 KiB hEeNoZsRecVsSimE
DQMHistoSizes: changed ( 25.0,... ): -40.656 KiB hEbNoZsRecVsSimE
DQMHistoSizes: changed ( 25.0,... ): -40.652 KiB hEbRecVsSimE
DQMHistoSizes: changed ( 25.0,... ): -40.652 KiB hEeRecVsSimE
DQMHistoSizes: changed ( 25.0,... ): -40.651 KiB h2TpVsEtSum
DQMHistoSizes: changed ( 25.0 ): ...
Checked 132 log files, 14 edm output root files, 32 DQM output files

ianna · 2019-08-01T21:15:44Z

+1

cmsbuild · 2019-08-01T21:16:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

kpedro88 · 2019-08-02T14:45:27Z

please test
(to get clean comparisons)

cmsbuild · 2019-08-02T14:45:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1808/console Started: 2019/08/02 16:46

cmsbuild · 2019-08-02T16:24:46Z

+1
Tested at: 389b250
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3f87c/1808/summary.html

cmsbuild · 2019-08-02T16:24:49Z

Comparison job queued.

cmsbuild · 2019-08-02T18:41:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3f87c/1808/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2492470
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2492152
DQMHistoTests: Total skipped: 317
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 132 log files, 14 edm output root files, 32 DQM output files

ianna · 2019-08-02T20:00:57Z

@kpedro88 - well, it's clean :-)

kpedro88 · 2019-08-02T21:36:23Z

+1

Mgrate Muon algorithms to their final destination directory

389b250

cmsbuild added this to the CMSSW_11_0_X milestone Aug 1, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Aug 1, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 1, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 1, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 1, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 1, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Aug 1, 2019

cmsbuild added comparison-pending tests-pending tests-started and removed comparison-available tests-approved tests-pending labels Aug 2, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 2, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 2, 2019

cmsbuild added orp-approved and removed orp-pending labels Aug 2, 2019

cmsbuild merged commit 810780f into cms-sw:master Aug 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DD4hep: Migrate Muon Algorithms to Geometry/MuonCommonData Package #27669

DD4hep: Migrate Muon Algorithms to Geometry/MuonCommonData Package #27669

ianna commented Aug 1, 2019

ianna commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019 •

edited

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

ianna commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

kpedro88 commented Aug 2, 2019

cmsbuild commented Aug 2, 2019 •

edited

cmsbuild commented Aug 2, 2019

cmsbuild commented Aug 2, 2019

cmsbuild commented Aug 2, 2019

ianna commented Aug 2, 2019

kpedro88 commented Aug 2, 2019

DD4hep: Migrate Muon Algorithms to Geometry/MuonCommonData Package #27669

DD4hep: Migrate Muon Algorithms to Geometry/MuonCommonData Package #27669

Conversation

ianna commented Aug 1, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

ianna commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019 • edited

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

ianna commented Aug 1, 2019

cmsbuild commented Aug 1, 2019

kpedro88 commented Aug 2, 2019

cmsbuild commented Aug 2, 2019 • edited

cmsbuild commented Aug 2, 2019

cmsbuild commented Aug 2, 2019

cmsbuild commented Aug 2, 2019

ianna commented Aug 2, 2019

kpedro88 commented Aug 2, 2019

cmsbuild commented Aug 1, 2019 •

edited

cmsbuild commented Aug 2, 2019 •

edited