Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumes migration1 #2763

Merged
merged 3 commits into from Mar 12, 2014
Merged

Consumes migration1 #2763

merged 3 commits into from Mar 12, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Mar 7, 2014

consumes migration for a bunch of remaining packages and code cleanup. more will come.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

A new Pull Request was created by @deguio for CMSSW_7_1_X.

Consumes migration1

It involves the following packages:

DQM/CSCMonitorModule
DQM/CastorMonitor
DQM/L1TMonitor
DQM/Physics
DQM/SiPixelMonitorRecHit
DQM/SiStripCommissioningSources
DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiStripMonitorHardware
DQM/SiStripMonitorPedestals
DQM/TrackerCommon
DQM/TrackingMonitor
DQM/TrigXMonitor
DQMOffline/CalibMuon
DQMOffline/EGamma
HLTriggerOffline/Egamma
Validation/CaloTowers
Validation/EcalClusters
Validation/EcalDigis
Validation/EventGenerator
Validation/GlobalDigis
Validation/GlobalRecHits
Validation/HcalRecHits
Validation/MuonDTDigis
Validation/MuonRPCGeometry
Validation/RecoEgamma

@vciulli, @civanch, @ojeda, @bendavid, @danduggan, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @rovere, @deguio, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@inugent, @argiro, @richard-cms, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

@deguio
Copy link
Contributor Author

deguio commented Mar 7, 2014

+1

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@vciulli
Copy link
Contributor

vciulli commented Mar 11, 2014

+1

@ianna
Copy link
Contributor

ianna commented Mar 12, 2014

+1

@cmsbuild
Copy link
Contributor

Pull request #2763 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@deguio
Copy link
Contributor Author

deguio commented Mar 12, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 12, 2014
DQM Consumes -- Consumes migration1
@nclopezo nclopezo merged commit 8ef9ae2 into cms-sw:CMSSW_7_1_X Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants