Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: HCal Algorithms Moved to Geometry/HcalAlgo Package #27668

Merged
merged 3 commits into from Aug 2, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 1, 2019

PR description:

  • Migrate DD4hep plugins to an agreed location under dd4hep directory
  • Fix them so that would run. This can be tested with a newly defined 2021 geometry scenario which is defined in DD4hep: Add 2021 CMS Geometry Scenario #27646
  • Merge declaration and definition for plugins
  • Avoid string copies
  • The rest is kept unchanged

Note: When #27637 is merged the GeantUnits should be replaced with CMSUnits

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor Author

ianna commented Aug 1, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27668/11238

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1776/console Started: 2019/08/01 17:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/HcalAlgo

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39024c/1776/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2484130
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2483812
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 1, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 2, 2019

+1

@cmsbuild cmsbuild merged commit 0c4a74d into cms-sw:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants