Run3-sim40 Move all files from interface/src to plugins for TB simulation

[bsunanda]

PR description:

Move the contents of interface/src of SimG4CMS/HGCalTestBeam to SimG4CMS/HcalTestBeam to the corresponding plugins as suggested by @smuzaffar

PR validation:

Tested with several TB applications

if this PR is a backport please specify the original PR:

Not needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27670/11242

• This PR adds an extra 52KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27670/11242/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27670/11242/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27670/11243

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/HGCalTestBeam
SimG4CMS/HcalTestBeam

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1779/console Started: 2019/08/01 18:30

[cmsbuild]

-1

Tested at: 58402a5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09a476/1779/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-01-1100/src/SimG4CMS/HGCalTestBeam/plugins/AHCalSD.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-01-1100/src/SimG4CMS/HGCalTestBeam/plugins/HGCalTBCheckGunPosition.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-01-1100/src/SimG4CMS/HGCalTestBeam/plugins/HGCPassive.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-01-1100/src/SimG4CMS/HGCalTestBeam/plugins/HGCalTB16SD01.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-01-1100/src/SimG4CMS/HGCalTestBeam/plugins/AHCalDetId.cc:1:0:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-01-1100/poison/SimG4CMS/HGCalTestBeam/interface/AHCalDetId.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-01-1100/src/SimG4CMS/HGCalTestBeam/plugins/AHCalDetId.cc:5:7: error: 'AHCalDetId' does not name a type
 const AHCalDetId AHCalDetId::Undefined(0, 0, 0);
       ^~~~~~~~~~


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27670/11245

• This PR adds an extra 56KB to repository

[cmsbuild]

Pull request #27670 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1780/console Started: 2019/08/01 20:04

[cmsbuild]

+1
Tested at: d17df39
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09a476/1780/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09a476/1780/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2492470
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2492152
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 132 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1