Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-TB39 Update the cfg files, now that the analyzers work with simulation #27680

Merged
merged 1 commit into from Aug 5, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 2, 2019

PR description:

With the changes in bigly, one can run the analyzers, filters in the same step of simulation. The configuration files are updated accordingly

PR validation:

Tested with private runs. They are not affecting any production workflows

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27680/11268

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/HGCalTestBeam

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 2, 2019

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1809/console Started: 2019/08/02 17:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3cbf16/1809/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2492470
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492152
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 2, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

@kpedro88 this PR does not affect production workflows, the tests look to run ok (checked the first one), so I will move it forward without waiting for your signature. Please comment it in case later

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

merge

@cmsbuild cmsbuild merged commit a91466a into cms-sw:master Aug 5, 2019
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants