-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to DT, PF hadron, HCAL, PPS and pixel calibrations for 2018 UL #27683
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27683/11278
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: Configuration/AlCa @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Why? |
@mmusich Are you asking why I am updating these conditions or why I am currently excluding the tracker+tracker alignment? The updates contained are independent of any forthcoming updates for the 2018 UL and so there's no reason not to introduce them now. As for the reason that tracker conditions are excluded: I would have included them but I was told at the tracker sign-off talk (I don't remember by whom) that it didn't make sense to update the tracker conditions without the updated tracker alignment. I can't include the tracker alignment tags here because the 2018 tracker alignment tags that also include the full history are not available. Since the tags include only 2018 IOVs, their inclusion would crash RelVals that run on earlier years. If I have misunderstood something, please feel free to correct me. |
The Pixel bad components are independent from the Tracker Alignment, and the 2D Template tag that has been requested (3 months ago) is coupled to the 1D template tag already in GT (it would actually solve an inconsistency currently present in the GT). |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27683/11283
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates most of the conditions for the 2018 UL that are not dependent on the tracker alignment. For 2018 data, this includes the DT, PF hadron, HCAL, PPS and pixel calibrations. For 2018 MC, only the PF hadron calibration and pixel bad components are updated. ECAL conditions are not included because the ECAL intercalibration is not ready.
GT candidates are used rather than versioned GTs because it is not clear whether this PR or #27644 would be merged first and I would like to avoid the confusion of out-of-order GT versions.
For data, only 2018 IOVs are modified. Consequently, only 2018 data and MC should be affected by this PR.
GT diffs (data):
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_v2/110X_dataRun2_2017_2018_Candidate_2019_08_03_03_51_45
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_v2/110X_dataRun2_relval_Candidate_2019_08_03_03_55_32
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HEfail_v1/110X_dataRun2_PromptLike_HEfail_Candidate_2019_08_02_16_55_52
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_v1/110X_dataRun2_PromptLike_Candidate_2019_08_02_16_53_14
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_PromptLike_HI_v1/110X_dataRun2_PromptLike_HI_Candidate_2019_08_02_16_55_18
GT diffs (MC):
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_v1/110X_upgrade2018_realistic_Candidate_2019_08_03_11_37_17
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HEfail_v1/110X_upgrade2018_realistic_HEfail_Candidate_2019_08_03_11_39_50
PR validation:
The payload validation has been described in sign-off talks at AlCa meetings:
DT: https://indico.cern.ch/event/832785/contributions/3489416/attachments/1876295/3097194/20190626_DTCalib_AlCaDBmeeting_SGhosh_v2.pdf
PF hadron: https://indico.cern.ch/event/834090/contributions/3495432/attachments/1880854/3098893/PFHadronCalibration_Alca_DB_15_July_2019.pdf
HCAL: https://indico.cern.ch/event/832785/contributions/3489397/attachments/1876358/3089810/Hcal_UL_2016_2018_July8_v1.pdf
PPS: https://indico.cern.ch/event/835589/#27-pps-calibration-sign-off-fo
Pixel: https://indico.cern.ch/event/834561/#25-tracker-sign-off-for-2018-u , https://indico.cern.ch/event/835589/contributions/3513525/attachments/1887574/3112176/20190729_AlCaDB_UL18FollowUp.pdf
In addition, a technical validation of the autoCond modifications has been performed:
runTheMatrix.py -l limited -i all --ibeos
if this PR is a backport please specify the original PR:
This is not a backport, though a 10_6_X backport will be needed.