enabling UL regression for 2018 (and likely Run3)

[Sam-Harper]

PR description:

This PR enables the 106X UL regressions for 2018, given the imminent update of these conditions in the GT.

The 2017UL is already in the global tags so matrix tests ran locally without errors. Of course they are not fully correct yet as they are not the 2018UL corrections.

Also from looking around at the modifiers it appears Run3 activates the egamma 2018 modifier so Run3 also gets this. Which is good, they should be using this.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27644/11178

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1773/console Started: 2019/08/01 16:11

[cmsbuild]

+1
Tested at: 6217e35
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fe69e/1773/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fe69e/1773/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3625 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2484130
• DQMHistoTests: Total failures: 1161
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 2482650
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.02 KiB( 31 files compared)
• DQMHistoSizes: changed ( 136.85 ): -0.020 KiB JetMET/SUSYDQM
• Checked 132 log files, 14 edm output root files, 32 DQM output files

[christopheralanwest]

I don't understand the comparison tests. There are differences in 2018 and 2026 workflows. Conditions have not yet been updated and both Run-3 and Phase-2 inherit from the previous Era. So I expected 2018, Run-3 and Run-4 workflows to switch to using the new 2017 regression, inducing reco changes in all three Eras. If this is unexpected, please resolve the issue prior to adding the updated GT candidates.

[Sam-Harper]

Indeed, it is puzzling that Run3 didnt change. Something to track down.

[Sam-Harper]

On closer inspection, Run3 does change. Just Run3 wasnt run in these tests which is odd. Anyways not my problem :D

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-07-31-2300+5fe69e/32888/

[Sam-Harper]

The full suite of runTheMatrix.py -l limited -i all --ibeos do pass though (which includes Run3, I also manually checked the config before and after this change and it is disabled/enabled as expected).

[christopheralanwest]

Does the same command work in a recent IB? I suspect that when 13 TeV workflows were moved to 14 TeV in #27433, a change should have been made to the list of RelVals selected by the "limited" option. The old RelVal 11624.0 does not exist anymore.

Attn: @zhenhu @kpedro88

[kpedro88]

@christopheralanwest good catch, I missed that in #27433. I'll submit a quick fix.

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2000/console Started: 2019/08/13 14:33

[cmsbuild]

+1
Tested at: f1e5398
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fe69e/2000/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fe69e/2000/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 11468 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 3707
• DQMHistoTests: Total nulls: 4
• DQMHistoTests: Total successes: 2935456
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.008 KiB( 33 files compared)
• DQMHistoSizes: changed ( 136.85 ): -0.008 KiB JetMET/SUSYDQM
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[christopheralanwest]

+1

Changes seen only in expected workflows:

• 2018 data and MC, including HI scenarios
• Run 3 MC
• pre-2017 data, as described in the response to enabling UL regression for 2018 (and likely Run3) #27644 (comment)

In particular, no changes are seen to pre-2018 MC or 2017 data.

The number of changes in comparison tests before and after the latest commit are the same, cross-checking that no unexpected changes were introduced in the last commit. For most workflows, the number of reco changes is the same. New differences are seen in:

• 4.53: Cosmics2011A
• 140.53: RunHI2011
• 1000.0: RunMiniBias2011A

These correspond to the addition of changes to the auto:run1_data (and the identical GT in auto:run2_data), which was mistakenly left unchanged relative to the version in master in the second-to-last commit.

There are changes to the number of reco differences in two workflows:

• 136.85: RunEGamma2018A
• 136.731: RunSinglePh2016B

The changes to the number of differences in 136.85 from the last commit is again a consequence of the modified auto:run2_data GT in the last commit. For workflow 136.731, the small number of changes is a consequence of using the HBHENegativeEFilter_v2.0_offline tag rather than HBHENegativeEFilter_v3.0_offline. Version 2.0 fixes the negative energy filter also for 2016 IOVs whereas 3.0 fixes the filter only for 2017 IOVs.

[slava77]

+1

for #27644 f1e5398

• code changes are in line with the PR description and the follow up review. Changes since the last reco signoff enabling UL regression for 2018 (and likely Run3) #27644 (comment) are only in the auto global tags https://github.com/cms-sw/cmssw/pull/27644/files/475caddc4631e417bb43875aff35b1357a488dbe..f1e5398eb0e16bdb55d9d22d85846f850203e8cf
• jenkins tests pass and comparisons with the baseline show more differences compared to the previous tests. Most notably, differences now appear also in pre-2017 data. This appears to be OK based on previous discussion and enabling UL regression for 2018 (and likely Run3) #27644 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1