Run3-TB40 Correct AHCal DetId for # of row/column and apply smearing for position/time #27697
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27697/11306
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27697/11307
|
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimG4CMS/HGCalTestBeam @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
Pull request #27697 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@kpedro88 I'll move this PR forward, please have a look at it at your earliest convenience |
|
+1 |
|
merge |
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Correct AHCal DetId to allow more cells along x/y and also extend the analysis routine of TB to include smearing for position and time
PR validation:
Tested with simulation of TB script as the standard workflow for CMS setup is unaffected by these changes
if this PR is a backport please specify the original PR:
Nothing special