Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: Tracker TEC Bridge overlaps #27701

Merged
merged 3 commits into from Aug 7, 2019
Merged

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Aug 6, 2019

PR description:

Addresses bridge overlaps due to DDTECPhiAltAlgo

PR validation:

master:

Screenshot from 2019-08-06 10-50-44

master + thisPr:

Screenshot from 2019-08-06 11-31-16

Reference:

Screenshot from 2019-08-06 10-53-36

Check #27689 for Validation instructions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27701/11313

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor

ianna commented Aug 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1852/console Started: 2019/08/06 11:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented Aug 6, 2019

+1

@fabiocos - the code is not used the RelVal comparison tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87718f/1852/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715659
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2019

+1

@cmsbuild cmsbuild merged commit 30cb186 into cms-sw:master Aug 7, 2019
@vargasa vargasa deleted the OverlapsBridge branch August 14, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants