Replace DecodingStructure struct with local unsigned integers

[IzaakWN]

PR description:

Replace DecodingStructure struct with local unsigned integer to solve issue #27533.

PR validation:

Successfully compiled and ran local test with SerializationSiPixelObjects.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27712/11329

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27712/11329/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27712/11329/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27712/11331

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @IzaakWN (Izaak) for master.

It involves the following packages:

CondFormats/SiPixelObjects

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng, @seemasharmafnal, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1895/console Started: 2019/08/08 10:41
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1900/console Started: 2019/08/08 12:01

[cmsbuild]

+1
Tested at: 65ac3cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-634099/1900/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #27712 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please check and sign again.

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1984/console Started: 2019/08/13 06:33

[cmsbuild]

+1
Tested at: b15a7af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-634099/1984/summary.html

[cmsbuild]

Comparison job queued.

[IzaakWN]

Hi all, sorry for the mess. The new commit, b15a7af, should fix the issues. Similar to the my previous commit, 4ee24ed, I had to be careful how to shift a std::vector<char>::const_iterator type:

*(char_it + 1 + int)

instead of

*(char_it + int) >> 8

I checked the behavior in this simple test code: http://cpp.sh/32ete, and found the same output as the previous method with DecodingStructure.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-634099/1984/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[ggovi]

+1

[fabiocos]

unhold

no difference is observed any more in the tests

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1