Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added [[fallthrough]] to SUSY_HLT_SingleLepton switch statements #27716

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This fixes a gcc 9 warning.

PR validation:

Tested using an gcc 9 based IB.
This is a technical change and should not affect results.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27716/11337

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

HLTriggerOffline/SUSYBSM

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@mtosi this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1878/console Started: 2019/08/07 21:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9063f9/1878/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715658
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fioriNTU
Copy link
Contributor

fioriNTU commented Aug 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2019

+1

@cmsbuild cmsbuild merged commit 0a40cf1 into cms-sw:master Aug 8, 2019
@Dr15Jones Dr15Jones deleted the fallthroughHLTriggerOfflineSUSYBSM branch August 15, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants