New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copy constructor for TRecHit1DMomConstraint #27719
Conversation
The gcc 9 compiler complained that the base class copy constructor was not being called. As the code was doing the same work as the default compiler written copy constructor, switched to using '= default'.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27719/11339
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoTracker/TransientTrackingRecHit @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The gcc 9 compiler complained that the base class copy constructor was not being called. As the code was doing the same work as the default compiler written copy constructor, switched to using
= default
.PR validation:
Tested compilation using a gcc 9 IB.
The change is technical and should not affect results unless the results were dependent on an incorrect copy constructor.