Replaced try...catch with ParameterSet::existsAs calls #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was causing dozens of exceptions to be thrown and then caught in production jobs. Since the code was only testing the existence of a ParameterSet it was easy to replace with existsAs. NOTE: It looks to me like this code is completely unnecessary. The loop just before this one goes over the exact same parameter names and asks for them as tracked parameters. If that succeeds, they can't also be untracked so the code modified does nothing. If that fails an exception is thrown and the code modified is never called.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Replaced try...catch with ParameterSet::existsAs calls It involves the following packages: HLTriggerOffline/Higgs @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks. |
|
+1 |
nclopezo
added a commit
that referenced
this pull request
Mar 11, 2014
…lysis HLTriggerOffline/Higgs -- Replaced try...catch with ParameterSet::existsAs calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was causing dozens of exceptions to be thrown and then
caught in production jobs. Since the code was only testing the
existence of a ParameterSet it was easy to replace with existsAs.
NOTE: It looks to me like this code is completely unnecessary.
The loop just before this one goes over the exact same parameter names
and asks for them as tracked parameters. If that succeeds, they can't
also be untracked so the code modified does nothing. If that fails
an exception is thrown and the code modified is never called.