Allow for ME0 triggers to be produced from pads directly

[dildick]

PR description:

Recent hardware developments by the GEM group argue for an FPGA-less ME0 front-end electronics design. This means that trigger pad clusters will not be produced in the L1-trigger chain during Phase-2. This is the currently the case in the simulation though. In Phase-2, ME0 triggers will be constructed out of trigger pads directly. This PR updates the simulation accordingly. More details can be found in this presentation: https://indico.cern.ch/event/831338/contributions/3482241/attachments/1869796/3079349/Change-ME0-001_CMS_Black.pdf.

I added a flag in the configuration to choose the input (pad or pad cluster). Other modifications include additional member data and a function that was templated.

PR validation:

I ran the workflow 20034.0 successfully.

There should be no change in the performance as ME0 pseudo-triggers are still the actual objects that are used in the L1T Muon chain.

FYI: @jshlee @tahuang1991 @rekovic

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27731/11361

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27731/11361/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27731/11361/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27731/11362

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/ME0Trigger

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@jshlee, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test workflow 20034.0

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1930/console Started: 2019/08/09 11:30

[cmsbuild]

+1
Tested at: 9cc8ac2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b93545/1930/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b93545/1930/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[cmsbuild]

Pull request #27731 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2434/console Started: 2019/09/09 15:49

[cmsbuild]

+1
Tested at: a056573
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b93545/2434/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b93545/2434/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2957224
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2956878
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[fabiocos]

@rekovic @benkrikler do you have comments about this PR?

[rekovic]

I am fine with this PR. We don't need to backport this to phase2-l1t-offline, as there should be no change in performance, so I would rather not push it there.

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1