Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx211 Modify the tests and try to put tests in HGCal Geometry area #27739

Merged
merged 1 commit into from Aug 13, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 9, 2019

PR description:

Modify the tests and test DD4Hep algorithms using similar xml files as for DDD

PR validation:

Make use of private tests

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27739/11376

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2019

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 9, 2019

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1945/console Started: 2019/08/10 01:23

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1310e/1945/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939165
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

+1

@ianna
Copy link
Contributor

ianna commented Aug 13, 2019

@kpedro88 - please review

@bsunanda
Copy link
Contributor Author

@ianna I did send you an email about one of the existing algos in a separate mail. Could you please take a look into this

@fabiocos
Copy link
Contributor

@kpedro88 this PR involves only test and developments geometries, and it looks ok to me to move forward

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1a0cdc9 into cms-sw:master Aug 13, 2019
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants