New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed thread-safety issues with PixelToFEDAssociateFromAscii #2775
Fixed thread-safety issues with PixelToFEDAssociateFromAscii #2775
Conversation
Changed the class statics to be member data. This avoids potential thread-safety issues. The additional minor changes were to support this change or to make mainentance easier. The exact functionality of this class was unchanged.
|
||
|
||
/// FED id to which barrel modul (identified by name) should be assigned | ||
virtual int operator()(const PixelBarrelName &) const; | ||
int operator()(const PixelBarrelName &) const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function was not declared in the base class and no classes inherit fro PixelToFEDAssociateFromAscii therefore no need for it to be virtual.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Fixed thread-safety issues with PixelToFEDAssociateFromAscii It involves the following packages: CalibTracker/SiPixelConnectivity @cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
…AsciiThreadSafe CalibTracker/SiPixelConnectivity -- Fixed thread-safety issues with PixelToFEDAssociateFromAscii
Changed the class statics to be member data. This avoids potential
thread-safety issues. The additional minor changes were to support
this change or to make mainentance easier. The exact functionality
of this class was unchanged.