Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed thread-safety issues with PixelToFEDAssociateFromAscii #2775

Conversation

Dr15Jones
Copy link
Contributor

Changed the class statics to be member data. This avoids potential
thread-safety issues. The additional minor changes were to support
this change or to make mainentance easier. The exact functionality
of this class was unchanged.

Changed the class statics to be member data. This avoids potential
thread-safety issues. The additional minor changes were to support
this change or to make mainentance easier. The exact functionality
of this class was unchanged.


/// FED id to which barrel modul (identified by name) should be assigned
virtual int operator()(const PixelBarrelName &) const;
int operator()(const PixelBarrelName &) const;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function was not declared in the base class and no classes inherit fro PixelToFEDAssociateFromAscii therefore no need for it to be virtual.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Fixed thread-safety issues with PixelToFEDAssociateFromAscii

It involves the following packages:

CalibTracker/SiPixelConnectivity

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@rcastello
Copy link

+1
if test is succesful

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 10, 2014
…AsciiThreadSafe

CalibTracker/SiPixelConnectivity -- Fixed thread-safety issues with PixelToFEDAssociateFromAscii
@nclopezo nclopezo merged commit 510120a into cms-sw:CMSSW_7_1_X Mar 10, 2014
@Dr15Jones Dr15Jones deleted the makePixelToFEDAssociationFromAsciiThreadSafe branch March 17, 2014 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants