Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dark photon 3000022 tracking for CMSSW_9_3_X #27765

Merged
merged 1 commit into from Aug 26, 2019

Conversation

weishi10141993
Copy link
Contributor

@weishi10141993 weishi10141993 commented Aug 13, 2019

Reference to #27754: Minor change to exclude Geant4 tracking of neutral dark photon 3000022 decaying (to muons) outside the CMS beam pipe.
Same PR (#27766) is done for CMSSW_10_2_X (2018 central MC production).

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2019

A new Pull Request was created by @weishi10141993 (Wei Shi) for CMSSW_9_3_X.

It involves the following packages:

SimG4Core/Generators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

@weishi10141993 weishi10141993 changed the title Exclude dark photon 3000022 tracking Exclude dark photon 3000022 tracking for CMSSW_9_3_X Aug 13, 2019
@weishi10141993
Copy link
Contributor Author

weishi10141993 commented Aug 14, 2019

cf. #27768 back port to 9_3_X, @civanch

@civanch
Copy link
Contributor

civanch commented Aug 15, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2035/console Started: 2019/08/15 10:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71a76c/2035/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 218
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624053
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@weishi10141993
Copy link
Contributor Author

Summary talk at simulation meeting:
https://indico.cern.ch/event/841826/#10-problem-of-dark-photon-simu

@civanch
Copy link
Contributor

civanch commented Aug 17, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

@weishi10141993
Copy link
Contributor Author

Hi, any news on this and #27766, #27778?

@kpedro88
Copy link
Contributor

backport of #27768

@kpedro88
Copy link
Contributor

The master branch PR has been integrated successfully. Making patch gen releases for 9_3, 10_2, and 10_6 is on the todo list.

@weishi10141993
Copy link
Contributor Author

Thanks @kpedro88 . Is there an estimated time when the patched releases will be available?

@kpedro88
Copy link
Contributor

@weishi10141993 probably early next week.

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5fbe192 into cms-sw:CMSSW_9_3_X Aug 26, 2019
@weishi10141993
Copy link
Contributor Author

@kpedro88 Thanks, I see the PRs are now merged. Where could I find the associated patched GEN releases? Will there be some notification/announcement when it comes out?

@kpedro88
Copy link
Contributor

The announcements have already been sent. Please subscribe to: https://hypernews.cern.ch/HyperNews/CMS/get/relAnnounce.html

@weishi10141993
Copy link
Contributor Author

I see. Thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants