Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dark photon 3000022 tracking for CMSSW_10_2_X #27766

Merged

Conversation

weishi10141993
Copy link
Contributor

Reference to #27754: Minor change to exclude Geant4 tracking of neutral dark photon 3000022 decaying (to muons) outside the CMS beam pipe.
Same PR (#27765) is done for CMSSW_9_3_X (2017 central MC production).

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2019

A new Pull Request was created by @weishi10141993 (Wei Shi) for CMSSW_10_2_X.

It involves the following packages:

SimG4Core/Generators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@weishi10141993
Copy link
Contributor Author

@civanch Please review this PR and PR #27765
I did 'scram b code-format' for both PR. It showed the following message. Not sure if that resolves the format issue.
$ scram build code-format

Local Products Rules ..... started
Local Products Rules ..... done
Unknow target code-format

@civanch
Copy link
Contributor

civanch commented Aug 13, 2019

@weishi10141993 , these PRs are fine. Code-format does not worked for these releases.

Please, make PR for the master - these PRs will not be considered before integration to the master. You may reopen closed one or make a new.

@weishi10141993
Copy link
Contributor Author

weishi10141993 commented Aug 13, 2019

@civanch Is there an instruction for how to make PR for master branch? I don't know how to do this.
Currently I followed: https://cms-sw.github.io/tutorial.html
I created the environment using 'cmsrel CMSSW_9_3_X' and 'cmsrel CMSSW_10_2_X'.
When I merge the current commit to master, it says can't automatically merge. So I can only merge to CMSSW_9_3_X and CMSSW_10_2_X respectively.

Is there a "cmsrel master" option?

@civanch
Copy link
Contributor

civanch commented Aug 13, 2019

@weishi10141993 , I am sorry, the master means CMSSW_11_0_X - the latest development IB using slc7_amd64_gcc700 architecture. Just now it is CMSSW_11_0_X_2019-08-13-1100. When you make commit from such IB you are automatically at master branch in GitHub

@weishi10141993
Copy link
Contributor Author

cf. #27768: back port to 10_2_X, @civanch

@civanch
Copy link
Contributor

civanch commented Aug 15, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2034/console Started: 2019/08/15 10:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba46d2/2034/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007277
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@weishi10141993
Copy link
Contributor Author

Summary talk at simulation meeting:
https://indico.cern.ch/event/841826/#10-problem-of-dark-photon-simu

@civanch
Copy link
Contributor

civanch commented Aug 17, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

backport of #27768

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6c7535c into cms-sw:CMSSW_10_2_X Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants