Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dark photon 3000022 tracking for CMSSW_10_6_X #27778

Conversation

weishi10141993
Copy link
Contributor

Minor change to exclude Geant4 tracking of neutral dark photon 3000022 decaying (to muons) outside the CMS beam pipe.
cf. #27768: back port to 10_6_X, @civanch

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2019

A new Pull Request was created by @weishi10141993 (Wei Shi) for CMSSW_10_6_X.

It involves the following packages:

SimG4Core/Generators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Aug 15, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2033/console Started: 2019/08/15 10:36

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ed61f/2033/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211049
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210713
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 15, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@weishi10141993
Copy link
Contributor Author

Summary talk at simulation meeting:
https://indico.cern.ch/event/841826/#10-problem-of-dark-photon-simu

@kpedro88
Copy link
Contributor

backport of #27768

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2019

+1

@cmsbuild cmsbuild merged commit 4ea4eae into cms-sw:CMSSW_10_6_X Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants