Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad-hoc fix of Relvals TaskName more than 50 characters #27779

Merged
merged 3 commits into from Aug 22, 2019

Conversation

chayanit
Copy link

@chayanit chayanit commented Aug 15, 2019

PR description:

This PR aims to fix the restriction of TaskName added by WMCore in (dmwm/WMCore@e15eee0) for RelVals injection. Mainly due to GEN fragment convention. The solution is to check if the TaskName is greater than 50 characters and

  • rename TaskName and InputTask to "GenSimFull" or "HadronizerFull"

PR validation:

Local test is done with one of the longest TaskName "DisplacedSUSY_stopToBottom_M_300_1000mm_TuneCUETP8M1_13TeV_pythia8_2018_GenSimFull"

runTheMatrix.py --what upgrade -l 10884.0

https://cmsweb.cern.ch/reqmgr2/fetch?rid=request-chayanit_RVCMSSW_11_0_0_pre5DisplacedSUSY_stopToBottom_M_300_1000mm_13_190820_164120_6223

The TaskName and InputTask is reduced to GenSimFull for this case

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27779/11464

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@chayanit
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2032/console Started: 2019/08/15 05:48

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e8bbc/2032/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939166
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@chayanit
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27779/11519

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 20, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2088/console Started: 2019/08/20 17:06

@cmsbuild
Copy link
Contributor

Pull request #27779 was updated. @cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e8bbc/2088/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939166
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Aug 22, 2019

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ef142d9 into cms-sw:master Aug 22, 2019
@Dr15Jones
Copy link
Contributor

This appears to have a python 3 problem:

/cvmfs/cms-ib.cern.ch/nweek-02590/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_11_0_X_2019-08-23-1100/external/slc7_amd64_gcc700/bin/python3 -m compileall -q src/GeneratorInterface/CosmicMuonGenerator/python
*** Error compiling 'src/Configuration/PyReleaseValidation/python/MatrixInjector.py'...
Sorry: TabError: inconsistent use of tabs and spaces in indentation (MatrixInjector.py, line 453)

@Dr15Jones
Copy link
Contributor

fixed with #27859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants