Fix gcc9 warnings L1Trigger/GlobalCaloTrigger #27827
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27827/11551
|
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: L1Trigger/GlobalCaloTrigger @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -305,6 +305,7 @@ void convertToGct(EmInputCandVec candidates) { | |||
| } else { | |||
| eta = 5; | |||
| } | |||
| [[fallthrough]]; | |||
| @@ -320,6 +321,7 @@ void convertToGct(EmInputCandVec candidates) { | |||
| } else { | |||
| eta = 3; | |||
| } | |||
| [[fallthrough]]; | |||
There was a problem hiding this comment.
Because with the current state the logic is to fallthrough and I was adding it where it was falling anyway. I was assuming breaks were forgotten, too, and then I've been told not to assume since the fallthrough were intentional. Some of them weren't but most were. Where they are forgotten I've added them like in here:
#27856
but in other places I've been told otherwise:
#27811 (comment)
Solution was to keep the existing logic until told to change it to break by responsible's.
|
+1 |
|
merge |
PR description:
Fix warnings in L1Trigger/GlobalCaloTrigger
PR validation:
Builds without warnings. Added [[fallthrough]] for every "missing" break.