python 3 fix for GlobalTag.py #27849
Conversation
python 3 does not allow comparison of a string to a None. This was occuring in the call to sorted. Replacing the None with '' allows the comparison to function and the final results are the same.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27849/11587
|
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Configuration/AlCa @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
@smuzaffar was the second test run done using DEVEL and that is why there were comparisons failures the second time? |
|
@Dr15Jones yes. I ran it to check the cmsdist PR with the code fixing the relvals. It worked as expected, and we built full IB with it to see the output of the new warning (see the cmsdist PR). |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@kpedro88 please approve this to fix problems in DEVEL_X |
|
+1 |
PR description:
python 3 does not allow comparison of a string to a None. This was occuring in the call to sorted. Replacing the None with '' allows the comparison to function and the final results are the
same.
PR validation:
The code was tested in the CMSSW_11_0_DEVEL_X IB which uses python 3 using the configuration generated for the 20661.97 workflow (which was failing in the IB). The resultant configuration for the PoolDBESSource is the same as for the original python 2 case.