Fix gcc9 warnings in Reco #27856
Fix gcc9 warnings in Reco #27856
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27856/11594
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: RecoCTPPS/TotemRPLocal @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
RecoCTPPS/TotemRPLocal/src/TotemTimingRecHitProducerAlgorithm.cc
Outdated
Show resolved
Hide resolved
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
comparison-available
tests-approved
labels
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27856/11833
|
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
The CSC bug, I think, assigned to ME1/1b values for ME1/2 instead of
its own. The noise and crosstalk values are only very slightly
different, and the constant terms are identical anyway. (They're
assigned per chamber type in the config file).
perrotta wrote on 9/11/19 18:22:
…
+1
* This PR, originally intended to be pretty technical, ended up
including a few bug fixes, implemented under the supervision and
with the agreement of the groups responsible of the relevant code:
o |reco::writeSpecific(reco::GenJet&, ...)| does not double
count any more muons and charged hadrons in GenJets;
o CSC local reco fixed in |CSCXonStrip_MatchGatti.cc|, where
|noise_level|, |xt_asymmetry| and |const_syst| of the ME13
chamber are not assigned to the ME12 any more
o Bug fix also in |TSGForRoadSearch.cc|, probably never or only
rarely hit, otherwise the warning "this should not happen...
ever. Please report. GeomDetEnumerators::PixelBarrel. no
seed." should have appeared in the log outputs
* Jenkins tests show the differences originated by the fix in the
CSC local reco, that propagate till to the final reconstructed muon
* No hint of the fix of GenJet's in the (low stat) jenkins tests:
this would probably need a larger stat and/or a dedicated validation
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27856?email_source=notifications&email_token=ABGYLHSBNWGY326BOJJOO73QJELNZA5CNFSM4IPBR7AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PCAEQ#issuecomment-530456594>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGYLHWX6NRZKZ3PSQOUWOLQJELNZANCNFSM4IPBR7AA>.
|
|
+1 |
PR description:
Fixes warnings for gcc9 in Reco
PR validation:
Builds without warnings. Last one for submission :)