Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcc9 warnings in Reco #27856

Merged
merged 4 commits into from Sep 12, 2019
Merged

Fix gcc9 warnings in Reco #27856

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3dba3c
Fix gcc9 warnings in Reco
mrodozov Aug 23, 2019
09fa6ef
Change int to float in enum type cast
mrodozov Aug 24, 2019
c30880f
Add breaks as discussed in the comments
mrodozov Sep 2, 2019
b8a5199
Remove fallthrough and add break as suggested in comments
mrodozov Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion RecoCTPPS/TotemRPLocal/src/TotemTimingRecHitProducerAlgorithm.cc
View file
Open in desktop
Expand Up @@ -191,5 +191,5 @@ float TotemTimingRecHitProducerAlgorithm::constantFractionDiscriminator(const st
(dataProcessed[indexOfThresholdCrossing - 1] - dataProcessed[indexOfThresholdCrossing]) *
(threshold - dataProcessed[indexOfThresholdCrossing]) +
time[indexOfThresholdCrossing]
: TotemTimingRecHit::NO_T_AVAILABLE;
: (float)TotemTimingRecHit::NO_T_AVAILABLE;
mrodozov marked this conversation as resolved.
Show resolved Hide resolved
}
1 change: 1 addition & 0 deletions RecoJets/JetProducers/plugins/InputGenJetsParticleSelector.cc
View file
Open in desktop
Expand Up @@ -198,6 +198,7 @@ InputGenJetsParticleSelector::ResonanceState InputGenJetsParticleSelector::fromR
return kDirect;
if (!isExcludedFromResonance(id))
break;
[[fallthrough]];
mrodozov marked this conversation as resolved.
Show resolved Hide resolved
case kIndirect:
return kIndirect;
}
Expand Down
1 change: 1 addition & 0 deletions RecoJets/JetProducers/src/JetSpecific.cc
View file
Open in desktop
Expand Up @@ -397,6 +397,7 @@ bool reco::makeSpecific(std::vector<reco::CandidatePtr> const& mcparticles, GenJ
case 13: // muon
genJetSpecific->m_MuonEnergy += e;
++(genJetSpecific->m_MuonMultiplicity);
[[fallthrough]];
mrodozov marked this conversation as resolved.
Show resolved Hide resolved
case 211: //pi+-
case 321: //K
case 2212: //p
Expand Down
1 change: 1 addition & 0 deletions RecoLocalMuon/CSCRecHitD/src/CSCXonStrip_MatchGatti.cc
View file
Open in desktop
Expand Up @@ -293,6 +293,7 @@ void CSCXonStrip_MatchGatti::findXOnStrip(const CSCDetId& id,
noise_level = noise_level_ME1b;
xt_asymmetry = xt_asymmetry_ME1b;
const_syst = const_syst_ME1b;
break;

case 3:
noise_level = noise_level_ME12;
Expand Down
1 change: 1 addition & 0 deletions RecoMuon/TrackerSeedGenerator/plugins/TSGForRoadSearch.cc
View file
Open in desktop
Expand Up @@ -426,6 +426,7 @@ void TSGForRoadSearch::makeSeeds_4(const reco::Track &muon, std::vector<Trajecto
edm::LogWarning(theCategory) << "ran out of layers to find a seed: no seed.";
return;
}
break;
}
case GeomDetEnumerators::PixelBarrel: {
edm::LogError(theCategory)
Expand Down