Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting generator filter modifications to CMSSW_9_3_X #27864

Conversation

danielwinterbottom
Copy link

PR description:

Backport of #27791 modifying EmbeddingHepMCFilter:

  • Setting the boson PDGID under option so that the filter can be used for Higgs events
  • Adding booleans to make sure the correct tau decay types are identified in cases where there are additional FSR photons
    These modifications are needed so that we can use this filter in a MC request for 2016, 2017, and 2018 MC samples and therefore need this to be backported to CMSSW_7_1_X, CMSSW_9_3_X, and CMSSW_10_2_X.
    The filter reduces the required statistics for our samples by a factor of 4 - without this filter the size of the sample required would be unfeasible to produce

PR validation:

  • Checked that the modifications compile in CMSSW_9_3_6_patch1
  • Checked by generating GEN-SIM events in CMSSW_9_3_6_patch1 that generator runs and that filter works correctly

if this PR is a backport please specify the original PR:

#27791

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @danielwinterbottom (Daniel Winterbottom) for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/Core
TauAnalysis/MCEmbeddingTools

@efeyazgan, @civanch, @mdhildreth, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy, @santocch can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Aug 25, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2172/console Started: 2019/08/25 16:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b800db/2172/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 218
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624053
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Aug 26, 2019

+1

@civanch
Copy link
Contributor

civanch commented Aug 27, 2019

+1

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7daf339 into cms-sw:CMSSW_9_3_X Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants