-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backporting generator filter modifications to CMSSW_9_3_X #27864
backporting generator filter modifications to CMSSW_9_3_X #27864
Conversation
A new Pull Request was created by @danielwinterbottom (Daniel Winterbottom) for CMSSW_9_3_X. It involves the following packages: GeneratorInterface/Core @efeyazgan, @civanch, @mdhildreth, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #27791 modifying EmbeddingHepMCFilter:
These modifications are needed so that we can use this filter in a MC request for 2016, 2017, and 2018 MC samples and therefore need this to be backported to CMSSW_7_1_X, CMSSW_9_3_X, and CMSSW_10_2_X.
The filter reduces the required statistics for our samples by a factor of 4 - without this filter the size of the sample required would be unfeasible to produce
PR validation:
if this PR is a backport please specify the original PR:
#27791