modifying filters to use with higgs samples #27791
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27791/11486
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27791/11487
|
|
A new Pull Request was created by @danielwinterbottom (Daniel Winterbottom) for master. It involves the following packages: GeneratorInterface/Core @efeyazgan, @civanch, @mdhildreth, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| if (std::abs((*daughter)->pdg_id()) == muonPDGID_) { | ||
| DecayChannel_.fill(TauDecayMode::Muon); | ||
| decaymode_known = true; | ||
| } else if (std::abs((*daughter)->pdg_id()) == electronPDGID_) { | ||
| DecayChannel_.fill(TauDecayMode::Electron); | ||
| decaymode_known = true; | ||
| } else if (!neutrino) { | ||
| } else if (!neutrino && !isGamma && !isTau) { | ||
| DecayChannel_.fill(TauDecayMode::Hadronic); |
There was a problem hiding this comment.
@danielwinterbottom , if it is not tau, why it has tau hadronic decay mode?
There was a problem hiding this comment.
These bools are related to the tau daughters not the particle itself. L 121 already requires the particle to be a tau. This condition is used to ensure that we ignore taus that aren't the last copy in the chain which is the case when there is FSR and the tau "decays" to a tau and a gamma
There was a problem hiding this comment.
is this ok should I hit "resolve conversation" ?
|
Sorry to be impatient but I was wondering if we can proceed with this pull request as we need these changes to be merged before we can submit a MC request for our analysis (and we also have to request backporting after which could cause further delays)? |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 8e280ec You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTauEmbeddingProducers had ERRORS |
|
Comparison job queued. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
PR validation:
Checked that the code compiles and that the modifications work correctly by generating MC events privately using the filter
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: