Filtering on pixel and strip clusters

[rchudasa]

PR description:

@echapon @slava77
This PR is submitted to filter out events with large activity in Pixel and Strip clusters for light by light analysis. The filtering reduces the timing of the reconstruction process by significant amount. The results has been presented in Reconstruction and Analysis Tools meeting.

https://indico.cern.ch/event/841640/contributions/3534139/attachments/1896758/3129554/CMS_Reco_23rdAug_2019.pdf

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27871/11626

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @rchudasa for master.

It involves the following packages:

RecoTracker/TkSeedGenerator

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

Aren't the third and fourth conditions in AND already included in the first two?

[slava77]

I agree.
@rchudasa please remove unnecessary parts of the cut

[rchudasa]

@perrotta , @slava77
Thanks, removed it. :)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27871/11629

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #27871 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2201/console Started: 2019/08/27 00:36

[cmsbuild]

+1
Tested at: 65fa2f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d7874/2201/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d7874/2201/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[slava77]

+1

for #27871 65fa2f9

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences (the modifications affect only jobs using egamma_lowPt_exclusive proc modifier
• local tests with a file from HIForward/HIRun2018A-v1/RAW run 326854 using 10K events show roughly expected behavior: the average event processing time is down by about 30% (from 1.5 s to 1.1 s), and the peak is down from 1.5E3 s to 60 s. The post-PR time peak is on one of the first events and is apparently driven by some condition or I/O overhead.
  • 8-thread job RSS peak dropped from 5.3 GiB to 3.3 GiB
  • At least from the technical point of view, this seems ready for production (no further optimization should be required).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1