Disabled PCA inputs for deepTau v2 (backport to 10_2_X)

[swozniewski]

PR description:

Problems have been detected with dxy_PCA input variables to DeepTauID which are inconsistent between data and MC. This PR sets input values to 0 and disables the variables this way.
Issue and fix were discussed in https://indico.cern.ch/event/842796/contributions/3541592/attachments/1897386/3130770/2019-08-26_DeepTau_ID_2017v2_DY_MC_vs_Embedded_and_bug_in_definition_of_PCA_variables.pdf (see slide 7 in particular)

Backport to 10_2_X for legacy analyses intended.

PR validation:

compiles

if this PR is a backport please specify the original PR:

#27878

[cmsbuild]

A new Pull Request was created by @swozniewski for CMSSW_10_2_X.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Disabled PCA inputs for deepTau v2 #27878

[cmsbuild]

Pull request #27879 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2232/console Started: 2019/08/28 13:55

[cmsbuild]

+1
Tested at: 783c595
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c1e42/2232/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c1e42/2232/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007274
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[cmsbuild]

Pull request #27879 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[mbluj]

Disabling of usage of dxy_PCA coordinates controlled with a parameter, and new version with the disabling added to the tauID python tool as in PR to master, but deepTauID is not included to any official workflow (as in production 10_2_X releases).

[perrotta]

+1

• "deepTau2017v2p1" id made available for legacy analyses, but not included in any official workflow
• Jenkins tests pass and show no differences, as they should

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #27878
(only partial)

[fabiocos]

please test workflow 136.7722,136.7952,136.8521,1325.6,1325.7,1325.8,1329.1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2624/console Started: 2019/09/23 16:25

[cmsbuild]

+1
Tested at: 0c68104
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c1e42/2624/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c1e42/2624/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007468
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007275
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

+1