Tk cloner

[VinInn]

This PR replaces 2752

From 2752

two technical improvements:
1) use SiStripRecHit2D in matcher instead of TTRH
1a) fix matcher for ARM
2) make PixelCPE output used in a single place
(next step will be to return all in a single call: example already in place in base class, need to be implemented in derived classes)
2) removed all setting of quality in SiPixelHit

more cleanup to come
I stop here because of 1a) and to allow work on PixelCPE

No regression observed.
No regression expected.

new improvements
3) cleanup of Constructors (as requested by @slava77)
4) introduction of a Cloner class to "clone' TkHits with a new track hypothesis

No regression observed.
No regression expected.

Next will be to change all Seeders to use only TkHIts (no TTRK)

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_1_X.

Tk cloner

It involves the following packages:

CommonTools/Utils
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
RecoLocalTracker/ClusterParameterEstimator
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripRecHitConverter
RecoMuon/GlobalTrackingTools
RecoTracker/MeasurementDet
RecoTracker/TrackProducer
RecoTracker/TransientTrackingRecHit
TrackingTools/KalmanUpdators
TrackingTools/TransientTrackingRecHit

@nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2789/423/summary.html

[VinInn]

as things are not moving fast, I took the opportunity to add one more improvements that recompiles
most of CMSSW
5) reduce size of SiPixelHIt and ProjectedHit
needless to say that those changes are "backward incompatible" for anybody (who?)
relying on reco to read and use Tracker RecHit. This is highly discouraged anyhow since CMSSW_2.

No regression observed.
No regression expected.

[cmsbuild]

Pull request #2789 was updated. @diguida, @danduggan, @rovere, @monttj, @cmsbuild, @anton-a, @thspeer, @rcastello, @deguio, @slava77, @vadler, @Degano, @ojeda, @nclopezo can you please check and sign again.

[diguida]

+1
In the AlCa code, there is only one change to accomodate the new DataFormats/TrackerRecHit2D/interface/ProjectedSiStripRecHit2D.h interface (maybe the call to the "old" member function SiStripRecHit2D ProjectedSiStripRecHit2D::originalHit() constcould be removed at all).

[VinInn]

@diguida etal.
I have done to ProjectedHit what already done to MatchedHits.
see
https://twiki.cern.ch/twiki/bin/viewauth/CMS/RecoPerformanceImprovement#SiStripRecHit2D
and https://twiki.cern.ch/twiki/bin/viewauth/CMS/SiStripMatchedRecHit2DFor520
for more details..

[diguida]

@VinInn
Thanks for the documentation. From a quick view, I'd say we could use the improvements in the calibration client code. Anyhow, I prefer to check in more details.

[VinInn]

@diguida the suggested action is "rm"

On 1 Feb, 2012, at 1:06 AM, Mario Galanti wrote:

together with that one, also the related files should go, so the full list of 
files to remove should be:

CalibTracker/SiStripLorentzAngle/interface/SiStripLAProfileBooker.h
CalibTracker/SiStripLorentzAngle/plugins/SiStripLAProfileBooker.cc
CalibTracker/SiStripLorentzAngle/python/SiStripLAProfileBooker_cfi.py
CalibTracker/SiStripLorentzAngle/test/SiStripLAProfileBooker.py

Moreover, the references from the deleted files should be removed from:

CalibTracker/SiStripLorentzAngle/plugins/modules.cc
CalibTracker/SiStripLorentzAngle/test/job_scripts/template.py

[diguida]

@VinInn
Thanks for finding this in your mails! In the twiki it was not mentioned.
If you want, I can make a PR removing those files.

[slava77]

looking at it

[slava77]

is this really needed? or is it temporary until rework is done?

[VinInn]

Thanks @slava77 for your comments. We will discuss among tracker's developer and will take action in a future PR

[slava77]

+1

for #2789 6e155a4
no differences as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?