BTL validation update

[casarsa]

PR description:

This is a refinement of PR #27607. The cumulative histogram BtlHitOccupancy was calculated and filled in BtlSimHitsValidation::endLuminosityBlock at step 3 and resulted not mergeable in the case of multiple parallel jobs. A new harvester module (BtlSimHitsHarvester) has been introduced and now the cumulative histogram filling is properly done at the harvesting step.

In addition, to deal with the huge number of BTL SIM/DIGI/RECO hits in the case of high PU events, the histograms with the number of hits are filled with the logarithm of the number of hits.

PR validation:

The updated code has been compiled in the release CMSSW_11_0_X_2019-08-21-2300 and tested with the WF 20434 and the WF 20607 with PU200.

The total size of the MTD monitoring plots is now:
476.28 KiB MTD/ETL
234.96 KiB MTD/BTL

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27891/11672

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27891/11672/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27891/11672/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly
• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27891/11672/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27891/11672/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27891/11675

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @casarsa (Massimo Casarsa) for master.

It involves the following packages:

Validation/Configuration
Validation/MtdValidation

@andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@apsallid, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2240/console Started: 2019/08/28 20:51

[cmsbuild]

+1
Tested at: 2c9a297
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42229c/2240/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42229c/2240/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 24
• DQMHistoTests: Total successes: 2939142
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -10.788 KiB( 33 files compared)
• DQMHistoSizes: changed ( 20034.0,... ): -2.697 KiB MTD/BTL
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[jfernan2]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1